Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubetail: install completions #51083

Merged
merged 1 commit into from Nov 28, 2018
Merged

kubetail: install completions #51083

merged 1 commit into from Nov 28, 2018

Conversation

yurrriq
Copy link
Member

@yurrriq yurrriq commented Nov 26, 2018 •
edited

Motivation for this change

Install completions for kubetail. N.B. I tested fish completions. YMMV with bash and zsh.. I've seen some confusion re: {ba,z}sh on Nix lately..

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: kubetail

Partial log (click to expand)

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/y9ypg81q8paczpv3h0da5krrmdlfh336-kubetail-1.6.5
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/y9ypg81q8paczpv3h0da5krrmdlfh336-kubetail-1.6.5/bin
patching script interpreter paths in /nix/store/y9ypg81q8paczpv3h0da5krrmdlfh336-kubetail-1.6.5
/nix/store/y9ypg81q8paczpv3h0da5krrmdlfh336-kubetail-1.6.5/bin/kubetail: interpreter directive changed from "/bin/bash" to "/nix/store/bpspdmsl0yys24gs70flsvcw3wcnl7lx-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/y9ypg81q8paczpv3h0da5krrmdlfh336-kubetail-1.6.5...
/nix/store/y9ypg81q8paczpv3h0da5krrmdlfh336-kubetail-1.6.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kubetail

Partial log (click to expand)

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zpzbqsz9y7fx7f44xmhkg58xj5q58dls-kubetail-1.6.5
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zpzbqsz9y7fx7f44xmhkg58xj5q58dls-kubetail-1.6.5/bin
patching script interpreter paths in /nix/store/zpzbqsz9y7fx7f44xmhkg58xj5q58dls-kubetail-1.6.5
/nix/store/zpzbqsz9y7fx7f44xmhkg58xj5q58dls-kubetail-1.6.5/bin/kubetail: interpreter directive changed from "/bin/bash" to "/nix/store/yal8k8rgbaj8p9vi08q1kh21ls0ndq95-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/zpzbqsz9y7fx7f44xmhkg58xj5q58dls-kubetail-1.6.5...
/nix/store/zpzbqsz9y7fx7f44xmhkg58xj5q58dls-kubetail-1.6.5

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 28, 2018

@kalbasit you okay with this as maintainer?
Seems perfectly sound to me but just want to be sure.

@kalbasit kalbasit self-requested a review November 28, 2018 20:40
@kalbasit
Copy link
Member

@c0bw3b it LGTM. Let me test out bash and zsh. I'll merge it if it works well.

@yurrriq
Copy link
Member Author

yurrriq commented Nov 28, 2018

Thanks, y'all!

@yurrriq yurrriq force-pushed the update/applications/networking/cluster/kubetail branch from 39a0c97 to e8b06fb Compare November 28, 2018 22:03
kalbasit
kalbasit approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@kalbasit kalbasit merged commit 6a0f0cc into NixOS:master Nov 28, 2018
@yurrriq
Copy link
Member Author

yurrriq commented Nov 28, 2018

🎉 Thanks for the quick response!

@yurrriq yurrriq deleted the update/applications/networking/cluster/kubetail branch November 28, 2018 22:06
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: kubetail

Partial log (click to expand)

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vmcfp7p7nbz46jbsjbc4y1rxm2p71b7i-kubetail-1.6.5
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vmcfp7p7nbz46jbsjbc4y1rxm2p71b7i-kubetail-1.6.5/bin
patching script interpreter paths in /nix/store/vmcfp7p7nbz46jbsjbc4y1rxm2p71b7i-kubetail-1.6.5
/nix/store/vmcfp7p7nbz46jbsjbc4y1rxm2p71b7i-kubetail-1.6.5/bin/kubetail: interpreter directive changed from "/bin/bash" to "/nix/store/bpspdmsl0yys24gs70flsvcw3wcnl7lx-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/vmcfp7p7nbz46jbsjbc4y1rxm2p71b7i-kubetail-1.6.5...
/nix/store/vmcfp7p7nbz46jbsjbc4y1rxm2p71b7i-kubetail-1.6.5

@kalbasit
Copy link
Member

Thanks for the quick response!

No problem, thank you for your contribution!

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kubetail

Partial log (click to expand)

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5lpd0sxr4hj47prp2kd8hf1hf2aj9lpi-kubetail-1.6.5
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5lpd0sxr4hj47prp2kd8hf1hf2aj9lpi-kubetail-1.6.5/bin
patching script interpreter paths in /nix/store/5lpd0sxr4hj47prp2kd8hf1hf2aj9lpi-kubetail-1.6.5
/nix/store/5lpd0sxr4hj47prp2kd8hf1hf2aj9lpi-kubetail-1.6.5/bin/kubetail: interpreter directive changed from "/bin/bash" to "/nix/store/yal8k8rgbaj8p9vi08q1kh21ls0ndq95-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/5lpd0sxr4hj47prp2kd8hf1hf2aj9lpi-kubetail-1.6.5...
/nix/store/5lpd0sxr4hj47prp2kd8hf1hf2aj9lpi-kubetail-1.6.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yurrriq @GrahamcOfBorg @c0bw3b @kalbasit