Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.rpy2: various fixes #51084

Merged
merged 1 commit into from Nov 27, 2018
Merged

pythonPackages.rpy2: various fixes #51084

merged 1 commit into from Nov 27, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Nov 26, 2018

Motivation for this change
  • make sure libreadline is found at runtime
  • make sure python libraries are found at runtime
  • add libraries necessary to pass the testsuite and standard libraries
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member Author

timokau commented Nov 26, 2018

@GrahamcOfBorg build python2.pkgs.rpy2 python3.pkgs.rpy2

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python2.pkgs.rpy2, python3.pkgs.rpy2

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.rpy2, python3.pkgs.rpy2

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kikk68kg9qixwd9xwnchb5jf19r4lq75-python3.7-rpy2-2.9.4
shrinking /nix/store/kikk68kg9qixwd9xwnchb5jf19r4lq75-python3.7-rpy2-2.9.4/lib/python3.7/site-packages/rpy2/rinterface/_rinterface.cpython-37m-x86_64-linux-gnu.so
shrinking /nix/store/kikk68kg9qixwd9xwnchb5jf19r4lq75-python3.7-rpy2-2.9.4/lib/python3.7/site-packages/rpy2/rinterface/_rpy_device.cpython-37m-x86_64-linux-gnu.so
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kikk68kg9qixwd9xwnchb5jf19r4lq75-python3.7-rpy2-2.9.4/lib
patching script interpreter paths in /nix/store/kikk68kg9qixwd9xwnchb5jf19r4lq75-python3.7-rpy2-2.9.4
checking for references to /build in /nix/store/kikk68kg9qixwd9xwnchb5jf19r4lq75-python3.7-rpy2-2.9.4...
/nix/store/br5f8jg9lrb75i9iczmibnbfp1r95php-python2.7-rpy2-2.8.6
/nix/store/kikk68kg9qixwd9xwnchb5jf19r4lq75-python3.7-rpy2-2.9.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.rpy2, python3.pkgs.rpy2

Partial log (click to expand)

shrinking /nix/store/fnws01bwfyv5yq0h08jz146zbk3gcswr-python3.7-rpy2-2.9.4/lib/python3.7/site-packages/rpy2/rinterface/_rinterface.cpython-37m-aarch64-linux-gnu.so
shrinking /nix/store/fnws01bwfyv5yq0h08jz146zbk3gcswr-python3.7-rpy2-2.9.4/lib/python3.7/site-packages/rpy2/rinterface/_rpy_device.cpython-37m-aarch64-linux-gnu.so
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fnws01bwfyv5yq0h08jz146zbk3gcswr-python3.7-rpy2-2.9.4/lib
patching script interpreter paths in /nix/store/s6sca387lxx1a4hpj1b22p61mniiijhm-python2.7-rpy2-2.8.6
checking for references to /build in /nix/store/s6sca387lxx1a4hpj1b22p61mniiijhm-python2.7-rpy2-2.8.6...
patching script interpreter paths in /nix/store/fnws01bwfyv5yq0h08jz146zbk3gcswr-python3.7-rpy2-2.9.4
checking for references to /build in /nix/store/fnws01bwfyv5yq0h08jz146zbk3gcswr-python3.7-rpy2-2.9.4...
/nix/store/s6sca387lxx1a4hpj1b22p61mniiijhm-python2.7-rpy2-2.8.6
/nix/store/fnws01bwfyv5yq0h08jz146zbk3gcswr-python3.7-rpy2-2.9.4

@timokau timokau changed the title pythonPackages.rpi2: various fixes pythonPackages.rpy2: various fixes Nov 26, 2018
@timokau
pythonPackages.rpy2: various fixes
32f29e0 
- make sure libreadline is found at runtime
- make sure python libraries are found at runtime
- add libraries necessary to pass the testsuite and standard libraries
@timokau timokau merged commit 63b39af into NixOS:master Nov 27, 2018
@timokau timokau deleted the rpy2-fixes branch November 27, 2018 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg