valgrind: disable parallel building on Darwin #51066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While testing an unrelated stdenv change, I was having trouble rebuilding this package on Darwin. It seems to be some sort of race where it tries to run `ar` on an object file that hasn't been built yet. I haven't had any problem building it (multiple times) since I disabled parallel building, so that seems to be the fix.
GrahamcOfBorg
added
6.topic: darwin
|
Success on x86_64-linux (full log) Attempted: valgrind Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: valgrind Partial log (click to expand)
|
|
@GrahamcOfBorg build valgrind |
|
Success on aarch64-linux (full log) Attempted: valgrind Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: valgrind Partial log (click to expand)
|
|
The same problem seems to affect linux too: https://hydra.nixos.org/build/84945477/nixlog/1 so it might be best to turn it off for all platforms. |
|
I assume this is superseded by #51082? I prefer this commit message tho 😄 . |
|
Could always do two commits, since it was discovered in two stages. Merge this then cherry-pick the other. I think it's merger's choice. :) Since there's a superseding PR, I'll close this one, but feel free to use the commit if it makes for a nicer story in the commit logs! |
|
Success on x86_64-darwin (full log) Attempted: valgrind Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
While testing an unrelated stdenv change, I was having trouble rebuilding this package on Darwin. It seems to be some sort of race where it tries to run
aron an object file that hasn't been built yet. I haven't had any problem building it (multiple times) since I disabled parallel building, so that seems to be the fix.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)