PICARD-1398: Fix installing locales when running setup.py bdist_wheel #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Both the Windows and Mac builds work and properly include the locales |
zas
approved these changes
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Builds for Snap package do not contain locale files.
Problem
Snap packages use
setup.py bdist_wheelfor generating the package. Currently the way our locale files are built causes them to be not included in the data package of the wheel.Solution
Fix installation of locale files to be in the proper data file used by the setuptools. This ensures not matter how the final packaging works the locale files will be included.
For now only tested locally with normal setup.py install and bdist_wheel commands. Before merging I want to test the CI builds for Win and Mac.
Action