Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cups-toshiba-estudio: fix homepage #51086

Merged
merged 1 commit into from Nov 27, 2018
Merged

cups-toshiba-estudio: fix homepage #51086

merged 1 commit into from Nov 27, 2018

Conversation

alexeymuranov
Copy link
Contributor

Provide an URL that works.

Motivation for this change

The URL in homepage attribute does not work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alexeymuranov
cups-toshiba-estudio: fix homepage
7725d9d 
Provide an URL that works.
@alexeymuranov
Copy link
Contributor Author

alexeymuranov commented Nov 26, 2018 •
edited

By the way, the current version in Nixpkgs is 7.89, while the latest available is 7.94 (2018-08-02). I do not know how to test it, so i am not going to make a PR for that.

@Mic92 Mic92 merged commit 3aa0294 into NixOS:master Nov 27, 2018
@Mic92
Copy link
Member

Mic92 commented Nov 27, 2018

cc @jpotier regarding the update.

@alexeymuranov alexeymuranov deleted the fix-estudio-web-page branch November 27, 2018 10:29
@jpotier
Copy link
Contributor

jpotier commented Nov 27, 2018

Well, I don't have that printer around anymore. So testing is going to be difficult. I could just up the version and hope it's ok, at the risk of breaking something that works.

@alexeymuranov
Copy link
Contributor Author

@jpotier I could try to test with e-studio3005AC if you give me detailed instructions. I am not really familiar with CUPS or nixpkgs, I am just a user of NixOS stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: printing 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexeymuranov @Mic92 @jpotier @GrahamcOfBorg