Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librepcb: 20181031 -> 0.1.0 #51087

Merged
merged 1 commit into from Nov 28, 2018
Merged

librepcb: 20181031 -> 0.1.0 #51087

merged 1 commit into from Nov 28, 2018

Conversation

Luz
Copy link
Contributor

@Luz Luz commented Nov 26, 2018

Motivation for this change

Update version to the first stable release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 26, 2018

Homepage should be https://librepcb.org/ now.

Note: nix won't see this as a newer version so users will need to uninstall librepcb-20181031 then install librepcb-0.1.0

nix-repl> lib.versionOlder "20181031" "0.1.0"
false

@Mic92
Copy link
Member

Mic92 commented Nov 27, 2018

Still I see no alternative to not using this version as version number.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 27, 2018

Yes, it was more for information if someone finds this PR later.
But it should keep version = "0.1.0" since it is indeed its upstream version number.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 28, 2018

@GrahamcOfBorg build librepcb

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: librepcb

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: librepcb

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/8i7c6blcpbifamycj0qh5rj9bbyms5vp-librepcb-0.1.0
shrinking /nix/store/8i7c6blcpbifamycj0qh5rj9bbyms5vp-librepcb-0.1.0/bin/librepcb
shrinking /nix/store/8i7c6blcpbifamycj0qh5rj9bbyms5vp-librepcb-0.1.0/bin/librepcb-cli
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8i7c6blcpbifamycj0qh5rj9bbyms5vp-librepcb-0.1.0/bin
patching script interpreter paths in /nix/store/8i7c6blcpbifamycj0qh5rj9bbyms5vp-librepcb-0.1.0
checking for references to /build in /nix/store/8i7c6blcpbifamycj0qh5rj9bbyms5vp-librepcb-0.1.0...
postPatchMkspecs
postPatchMkspecs
/nix/store/8i7c6blcpbifamycj0qh5rj9bbyms5vp-librepcb-0.1.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: librepcb

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/jssa7i931bmbmzczwv4czq15lw1pgnag-librepcb-0.1.0
shrinking /nix/store/jssa7i931bmbmzczwv4czq15lw1pgnag-librepcb-0.1.0/bin/librepcb-cli
shrinking /nix/store/jssa7i931bmbmzczwv4czq15lw1pgnag-librepcb-0.1.0/bin/librepcb
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jssa7i931bmbmzczwv4czq15lw1pgnag-librepcb-0.1.0/bin
patching script interpreter paths in /nix/store/jssa7i931bmbmzczwv4czq15lw1pgnag-librepcb-0.1.0
checking for references to /build in /nix/store/jssa7i931bmbmzczwv4czq15lw1pgnag-librepcb-0.1.0...
postPatchMkspecs
postPatchMkspecs
/nix/store/jssa7i931bmbmzczwv4czq15lw1pgnag-librepcb-0.1.0

@c0bw3b c0bw3b merged commit d209180 into NixOS:master Nov 28, 2018
@c0bw3b c0bw3b mentioned this pull request Dec 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Luz @c0bw3b @Mic92 @GrahamcOfBorg