Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stern: build shell completion scripts even when cross-compiling #51075

Merged
merged 1 commit into from Nov 27, 2018
Merged

stern: build shell completion scripts even when cross-compiling #51075

merged 1 commit into from Nov 27, 2018

Conversation

benley
Copy link
Member

@benley benley commented Nov 26, 2018

Moments after merging #49668 I realized that this is not hard to do correctly, so here it is now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@benley
stern: build shell completion scripts even when cross-compiling
5788261 
Moments after merging NixOS#49668 I realized that this is not hard to do
correctly, so here it is now.
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: stern

Partial log (click to expand)

/nix/store/2mc8j39gbsf3hcfyd2zpc70k4pzsha6d-stern-1.10.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: stern

Partial log (click to expand)

/nix/store/5x2is76b1k9wlq1wcninl48xz0zqn3kg-stern-1.10.0-bin

@benley benley requested review from Mic92 and roberth November 26, 2018 21:11
roberth
roberth approved these changes Nov 26, 2018
View reviewed changes
Copy link
Member

@roberth roberth left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to check whether the output only references cross binaries, but failed due to another problem.
Cross build seems to fail to build go at this time. After merging master, I tried

nix-build --expr '(import ./. { crossSystem = (import ./lib).systems.examples.aarch64-multiplatform; })' -A stern

However, by running the command (--completion etc) by hand, I could confirm that it does not reference any store path! 🎆

@benley
Copy link
Member Author

benley commented Nov 27, 2018

@roberth thank you for verifying!

@benley benley merged commit 551cee2 into NixOS:master Nov 27, 2018
@benley benley deleted the benley/stern-completion branch November 27, 2018 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberth roberth roberth approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benley @GrahamcOfBorg @roberth