Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dosbox: 0.74 -> 0.74-2 #50216

Merged
merged 2 commits into from Nov 11, 2018
Merged

dosbox: 0.74 -> 0.74-2 #50216

merged 2 commits into from Nov 11, 2018

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Nov 11, 2018

Motivation for this change

Changelog: https://sourceforge.net/projects/dosbox/files/dosbox/0.74-2/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: SDL_sound, dosbox

Partial log (click to expand)

make[2]: Entering directory '/private/tmp/nix-build-dosbox-0.74-2.drv-0/dosbox-0.74-2'
make[2]: Nothing to be done for 'install-exec-am'.
make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/private/tmp/nix-build-dosbox-0.74-2.drv-0/dosbox-0.74-2'
make[1]: Leaving directory '/private/tmp/nix-build-dosbox-0.74-2.drv-0/dosbox-0.74-2'
post-installation fixup
gzipping man pages under /nix/store/g5dvd9fg608q72ilwxbxg6nxmj82qvgn-dosbox-0.74-2/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/g5dvd9fg608q72ilwxbxg6nxmj82qvgn-dosbox-0.74-2/bin
patching script interpreter paths in /nix/store/g5dvd9fg608q72ilwxbxg6nxmj82qvgn-dosbox-0.74-2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: SDL_sound, dosbox

Partial log (click to expand)

make[2]: Leaving directory '/build/dosbox-0.74-2'
make[1]: Leaving directory '/build/dosbox-0.74-2'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wndl0arcy84db53iwkir73gcbgychpzb-dosbox-0.74-2
shrinking /nix/store/wndl0arcy84db53iwkir73gcbgychpzb-dosbox-0.74-2/bin/dosbox
gzipping man pages under /nix/store/wndl0arcy84db53iwkir73gcbgychpzb-dosbox-0.74-2/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wndl0arcy84db53iwkir73gcbgychpzb-dosbox-0.74-2/bin
patching script interpreter paths in /nix/store/wndl0arcy84db53iwkir73gcbgychpzb-dosbox-0.74-2
checking for references to /build in /nix/store/wndl0arcy84db53iwkir73gcbgychpzb-dosbox-0.74-2...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: SDL_sound, dosbox

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zxb93822jh8vanbxhh5dn4bmr975c3rr-dosbox-0.74-2
shrinking /nix/store/zxb93822jh8vanbxhh5dn4bmr975c3rr-dosbox-0.74-2/bin/dosbox
gzipping man pages under /nix/store/zxb93822jh8vanbxhh5dn4bmr975c3rr-dosbox-0.74-2/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zxb93822jh8vanbxhh5dn4bmr975c3rr-dosbox-0.74-2/bin
patching script interpreter paths in /nix/store/zxb93822jh8vanbxhh5dn4bmr975c3rr-dosbox-0.74-2
checking for references to /build in /nix/store/zxb93822jh8vanbxhh5dn4bmr975c3rr-dosbox-0.74-2...
/nix/store/6xswwv00kacyg5i2khfnwv8jv9psyskq-SDL_sound-1.0.3
/nix/store/zxb93822jh8vanbxhh5dn4bmr975c3rr-dosbox-0.74-2

@orivej-nixos orivej-nixos merged commit 59ddb14 into NixOS:master Nov 11, 2018
@orivej orivej deleted the dosbox branch November 11, 2018 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orivej @GrahamcOfBorg @orivej-nixos