Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-latexdiff: 1.1.2 -> 1.3.0 #50217

Merged
merged 2 commits into from Nov 18, 2018
Merged

git-latexdiff: 1.1.2 -> 1.3.0 #50217

merged 2 commits into from Nov 18, 2018

Conversation

qfjp
Copy link
Contributor

@qfjp qfjp commented Nov 11, 2018

Motivation for this change

git-latexdiff was three years old at v1.1.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

timokau
timokau requested changes Nov 11, 2018
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to make this update, but please actually read Contributing.md and amend your commit message accordingly.

pkgs/tools/typesetting/git-latexdiff/shebang.patch
@@ -6,5 +6,5 @@ Fix for https://gitlab.com/git-latexdiff/git-latexdiff/issues/8
-#! /bin/bash
+#!/usr/bin/env bash

# Main author: Matthieu Moy <Matthieu.Moy@imag.fr> (2012 - 2015)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole patch should be replaced by patchShebangs src/git-latexdiff.

@teto
Copy link
Member

teto commented Nov 12, 2018

In the meta part, you may want to add the homepage (https://gitlab.com/git-latexdiff ?).

@c0bw3b c0bw3b changed the title Update git-latexdiff to v1.3.0 git-latexdiff: 1.1.2 -> 1.3.0 Nov 18, 2018
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 18, 2018

@GrahamcOfBorg build git-latexdiff

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: git-latexdiff

Partial log (click to expand)

configuring
no configure script, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/s0hhhxg41fq05zrfxrig5235j8sq9pcp-git-latexdiff-1.3.0
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/s0hhhxg41fq05zrfxrig5235j8sq9pcp-git-latexdiff-1.3.0/bin
patching script interpreter paths in /nix/store/s0hhhxg41fq05zrfxrig5235j8sq9pcp-git-latexdiff-1.3.0
checking for references to /build in /nix/store/s0hhhxg41fq05zrfxrig5235j8sq9pcp-git-latexdiff-1.3.0...
/nix/store/s0hhhxg41fq05zrfxrig5235j8sq9pcp-git-latexdiff-1.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: git-latexdiff

Partial log (click to expand)

configuring
no configure script, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vbbi1b5r7p65rcjyigpynrzh89ca7w3v-git-latexdiff-1.3.0
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vbbi1b5r7p65rcjyigpynrzh89ca7w3v-git-latexdiff-1.3.0/bin
patching script interpreter paths in /nix/store/vbbi1b5r7p65rcjyigpynrzh89ca7w3v-git-latexdiff-1.3.0
checking for references to /build in /nix/store/vbbi1b5r7p65rcjyigpynrzh89ca7w3v-git-latexdiff-1.3.0...
/nix/store/vbbi1b5r7p65rcjyigpynrzh89ca7w3v-git-latexdiff-1.3.0

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 18, 2018

@GrahamcOfBorg eval

@c0bw3b c0bw3b merged commit a6ddb1f into NixOS:master Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@qfjp @teto @c0bw3b @GrahamcOfBorg @timokau