Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire-desktop: don't explicitly set phases #50219

Merged
merged 1 commit into from Nov 11, 2018
Merged

wire-desktop: don't explicitly set phases #50219

merged 1 commit into from Nov 11, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

part of #28910

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: wire-desktop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: wire-desktop

Partial log (click to expand)

no configure script, doing nothing
installing
post-installation fixup
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2nrrf87i11cjy6fvg4yiqfi7nkh7zk09-wire-desktop-3.3.2872/bin
patching script interpreter paths in /nix/store/2nrrf87i11cjy6fvg4yiqfi7nkh7zk09-wire-desktop-3.3.2872
/nix/store/2nrrf87i11cjy6fvg4yiqfi7nkh7zk09-wire-desktop-3.3.2872/opt/Wire/resources/app/node_modules/ajv/scripts/prepare-tests: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/2nrrf87i11cjy6fvg4yiqfi7nkh7zk09-wire-desktop-3.3.2872/opt/Wire/resources/app/node_modules/ajv/scripts/travis-gh-pages: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/2nrrf87i11cjy6fvg4yiqfi7nkh7zk09-wire-desktop-3.3.2872...
/nix/store/2nrrf87i11cjy6fvg4yiqfi7nkh7zk09-wire-desktop-3.3.2872

@Mic92 Mic92 merged commit 8905ca4 into NixOS:master Nov 11, 2018
@worldofpeace worldofpeace deleted the wire-desktop/no-explicit-phases branch November 11, 2018 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @GrahamcOfBorg @Mic92