docker-compose: rename from docker_compose, python3 by default #50176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jgeerds |
|
Success on x86_64-linux (full log) Attempted: docker-compose Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: docker-compose Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: docker-compose Partial log (click to expand)
|
FRidh
reviewed
Nov 11, 2018
pkgs/top-level/python-packages.nix
Outdated
| @@ -2220,7 +2220,8 @@ in { | |||
|
|
|||
| pyfribidi = callPackage ../development/python-modules/pyfribidi { }; | |||
|
|
|||
| docker_compose = callPackage ../development/python-modules/docker_compose {}; | |||
| docker-compose = callPackage ../development/python-modules/docker_compose {}; | |||
| docker_compose = self.docker-compose; # legacy alias | |||
There was a problem hiding this comment.
Please don't add aliases. They only make it more confusing when overriding stuff. Because users eventually will have to update their expressions, and because an alias like this doesn't cause any notification of it, I don't see the point of it.
There was a problem hiding this comment.
I moved it out of python-packages.nix since it is not a library.
Mic92
force-pushed
the
docker-componse
branch
from
bafaad4
to
0c773cc
Compare
The command is called docker-compose hence the package should be called the same. Also prefer python3.
Mic92
force-pushed
the
docker-componse
branch
from
0c773cc
to
7a86bc3
Compare
|
Success on x86_64-linux (full log) Attempted: docker-compose Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: docker-compose Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: docker-compose Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command is called docker-compose hence the package should be called the same.
Also prefer python3.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)