Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: remove docker- prefix from containerd and runc #50203

Closed
wants to merge 1 commit into from
Closed

docker: remove docker- prefix from containerd and runc #50203

wants to merge 1 commit into from

Conversation

jokogr
Copy link
Contributor

@jokogr jokogr commented Nov 10, 2018

Motivation for this change

Latest Docker changed the required filenames for the containerd and runc binaries as can be seen at docker/docker-ce@f30fc76.

This commit drops the docker- prefix

I have run locally the docker test and finishes successfully again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@eadwu
Copy link
Member

eadwu commented Nov 10, 2018

Seems to be working fine now, built and tested locally.

@eadwu
Copy link
Member

eadwu commented Nov 11, 2018

Looks like it's in master at 68c3e5f now?

@jokogr
Copy link
Contributor Author

jokogr commented Nov 11, 2018

Indeed it is.

@jokogr jokogr closed this Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jokogr @eadwu @GrahamcOfBorg