Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix FHSUserEnv blacklists #50235

Merged
merged 1 commit into from Nov 28, 2018

Conversation

illegalprime
Copy link
Member

Motivation for this change

While attempting to package yocto, which is a source based tool chain to build embedded Linux OSes I found it was downloading binaries to bootstrap compilation of Rust and other langs. I then switched to FHSUserEnv but my host /lib was still available within the chroot so binaries kept breaking because, I believe, a mismatch of glibc versions across chroot and host.

To make the chroot more pure, I have added "lib", "lib64", "lib32", "sbin" to the chroot blacklist.
I believe that Steam makes heavy use of this so I need to test that before merging.

Maybe it would be better to have a custom set of blacklists (or even whitelists) when creating this chroot? If that is preferable let me know and I'll try to implement.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from lukateras November 13, 2018 20:55
@illegalprime
Copy link
Member Author

Thanks @matthewbauer , what do I need to get this merged?

@matthewbauer matthewbauer merged commit 7fa8c41 into NixOS:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants