Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncplay: 1.5.5 -> 1.6.0 #50213

Merged
merged 1 commit into from Nov 11, 2018
Merged

syncplay: 1.5.5 -> 1.6.0 #50213

merged 1 commit into from Nov 11, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

fixes #49928

Switched to python3 as per syncplay-server output

Traceback (most recent call last):
  File "/nix/store/zamfk74l1wn144q45k6cxyjz8famdbzv-syncplay-1.6.0/bin/.syncplay-server-wrapped", line 13, in <module>
    raise Exception("You must run Syncplay with Python 3.4 or newer!")
Exception: You must run Syncplay with Python 3.4 or newer!

Currently appears to work correctly now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @Mic92

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: syncplay

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/9c0zpv22sv1f2vavhjkd0w3wvxbjpr9x-syncplay-1.6.0/lib  /nix/store/9c0zpv22sv1f2vavhjkd0w3wvxbjpr9x-syncplay-1.6.0/bin
patching script interpreter paths in /nix/store/9c0zpv22sv1f2vavhjkd0w3wvxbjpr9x-syncplay-1.6.0
/nix/store/9c0zpv22sv1f2vavhjkd0w3wvxbjpr9x-syncplay-1.6.0/lib/syncplay/syncplayClient.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/bwfygfcdvis9wd1c1v51xwnwhw1hx0a0-python3-3.6.6/bin/python3"
/nix/store/9c0zpv22sv1f2vavhjkd0w3wvxbjpr9x-syncplay-1.6.0/lib/syncplay/syncplayServer.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/bwfygfcdvis9wd1c1v51xwnwhw1hx0a0-python3-3.6.6/bin/python3"
/nix/store/9c0zpv22sv1f2vavhjkd0w3wvxbjpr9x-syncplay-1.6.0/bin/syncplay-server: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/bwfygfcdvis9wd1c1v51xwnwhw1hx0a0-python3-3.6.6/bin/python3"
/nix/store/9c0zpv22sv1f2vavhjkd0w3wvxbjpr9x-syncplay-1.6.0/bin/syncplay: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/bwfygfcdvis9wd1c1v51xwnwhw1hx0a0-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/9c0zpv22sv1f2vavhjkd0w3wvxbjpr9x-syncplay-1.6.0...
wrapping `/nix/store/9c0zpv22sv1f2vavhjkd0w3wvxbjpr9x-syncplay-1.6.0/bin/syncplay-server'...
wrapping `/nix/store/9c0zpv22sv1f2vavhjkd0w3wvxbjpr9x-syncplay-1.6.0/bin/syncplay'...
/nix/store/9c0zpv22sv1f2vavhjkd0w3wvxbjpr9x-syncplay-1.6.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: syncplay

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/am7c2rf918hdgwjdyrndsa62dh8naj76-syncplay-1.6.0/lib  /nix/store/am7c2rf918hdgwjdyrndsa62dh8naj76-syncplay-1.6.0/bin
patching script interpreter paths in /nix/store/am7c2rf918hdgwjdyrndsa62dh8naj76-syncplay-1.6.0
/nix/store/am7c2rf918hdgwjdyrndsa62dh8naj76-syncplay-1.6.0/bin/syncplay-server: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/16wqq9ihrkdim3x8xs1lkxa3f4l3p3ir-python3-3.6.6/bin/python3"
/nix/store/am7c2rf918hdgwjdyrndsa62dh8naj76-syncplay-1.6.0/bin/syncplay: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/16wqq9ihrkdim3x8xs1lkxa3f4l3p3ir-python3-3.6.6/bin/python3"
/nix/store/am7c2rf918hdgwjdyrndsa62dh8naj76-syncplay-1.6.0/lib/syncplay/syncplayServer.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/16wqq9ihrkdim3x8xs1lkxa3f4l3p3ir-python3-3.6.6/bin/python3"
/nix/store/am7c2rf918hdgwjdyrndsa62dh8naj76-syncplay-1.6.0/lib/syncplay/syncplayClient.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/16wqq9ihrkdim3x8xs1lkxa3f4l3p3ir-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/am7c2rf918hdgwjdyrndsa62dh8naj76-syncplay-1.6.0...
wrapping `/nix/store/am7c2rf918hdgwjdyrndsa62dh8naj76-syncplay-1.6.0/bin/syncplay'...
wrapping `/nix/store/am7c2rf918hdgwjdyrndsa62dh8naj76-syncplay-1.6.0/bin/syncplay-server'...
/nix/store/am7c2rf918hdgwjdyrndsa62dh8naj76-syncplay-1.6.0

@infinisil infinisil merged commit 337f8f7 into NixOS:master Nov 11, 2018
@worldofpeace worldofpeace deleted the syncplay/1.6.0 branch November 11, 2018 01:14
@worldofpeace
Copy link
Contributor Author

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @GrahamcOfBorg @infinisil