Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qtwebglplugin: init at 5.11 #50207

Merged
merged 1 commit into from Nov 11, 2018
Merged

qtwebglplugin: init at 5.11 #50207

merged 1 commit into from Nov 11, 2018

Conversation

Thra11
Copy link
Member

@Thra11 Thra11 commented Nov 10, 2018

Note: As with all Qt plugins, must set QT_QPA_PLATFORM_PLUGIN_PATH=~/.nix-profile/lib/qt-5.11/plugins for it to be found.

Motivation for this change

qtwebglplugin wasn't packaged

Things done

Added a Qt module

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Note: To test/use this, you need to:
Set QT_QPA_PLATFORM_PLUGIN_PATH=~/.nix-profile/lib/qt-5.11/plugins
Run a Qt Quick application, either with the environment variable QT_QPA_PLATFORM=webgl or with the argument -platform webgl
Point a WebGL-capable browser at <IP address>:8080.
I tested it with a number of the examples in the qt sources in qtdeclarative/examples.

@Thra11 Thra11 requested a review from ttuegel as a code owner November 10, 2018 19:27
worldofpeace
worldofpeace suggested changes Nov 10, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure, according to the contribution guidelines, that the commit msg should be

qtwebglplugin: init at 5.11

@Thra11
qtwebglplugin: init at 5.11
230f714 
Note: As with all Qt plugins, must set QT_QPA_PLATFORM_PLUGIN_PATH=~/.nix-profile/lib/qt-5.11/plugins for it to be found.
@Thra11 Thra11 changed the title qtwebglplugin: init @ 5.11 qtwebglplugin: init at 5.11 Nov 10, 2018
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build qt5.qtwebglplugin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: qt5.qtwebglplugin

Partial log (click to expand)

checking for references to /build in /nix/store/4kbc2qayqrsd1mf3a7ak1zgb6r6l12rh-qtwebglplugin-5.11.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/7srqp44cwwmwq7d2z1916dja4786a7g8-qtwebglplugin-5.11.1-dev
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7srqp44cwwmwq7d2z1916dja4786a7g8-qtwebglplugin-5.11.1-dev/lib
patching script interpreter paths in /nix/store/7srqp44cwwmwq7d2z1916dja4786a7g8-qtwebglplugin-5.11.1-dev
checking for references to /build in /nix/store/7srqp44cwwmwq7d2z1916dja4786a7g8-qtwebglplugin-5.11.1-dev...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/4kbc2qayqrsd1mf3a7ak1zgb6r6l12rh-qtwebglplugin-5.11.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: qt5.qtwebglplugin

Partial log (click to expand)

checking for references to /build in /nix/store/sgly3ndwx7ddcg368gkxm3xa0l6vv8da-qtwebglplugin-5.11.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/2w2kmxicya2jvkln0zwh8pvalghfyk4h-qtwebglplugin-5.11.1-dev
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2w2kmxicya2jvkln0zwh8pvalghfyk4h-qtwebglplugin-5.11.1-dev/lib
patching script interpreter paths in /nix/store/2w2kmxicya2jvkln0zwh8pvalghfyk4h-qtwebglplugin-5.11.1-dev
checking for references to /build in /nix/store/2w2kmxicya2jvkln0zwh8pvalghfyk4h-qtwebglplugin-5.11.1-dev...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/sgly3ndwx7ddcg368gkxm3xa0l6vv8da-qtwebglplugin-5.11.1

worldofpeace
worldofpeace approved these changes Nov 10, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not to familiar with qt packaging in nixpkgs, but this appears fine to me.

@ttuegel ttuegel merged commit b529b81 into NixOS:master Nov 11, 2018
@ttuegel
Copy link
Member

ttuegel commented Nov 11, 2018

Thanks!

@Thra11 Thra11 deleted the qtwebglplugin branch November 11, 2018 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Thra11 @worldofpeace @GrahamcOfBorg @ttuegel