Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fusuma: init at 0.10.2 #50191

Merged
merged 1 commit into from Nov 18, 2018
Merged

fusuma: init at 0.10.2 #50191

merged 1 commit into from Nov 18, 2018

Conversation

jfrankenau
Copy link
Member

Motivation for this change

In contrast to libinput-gestures fusuma supports repeating commands which for example makes pinch to zoom much more pleasurable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @teozkr

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build fusuma

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fusuma

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/yqphkpvgw9hrlbv32i3y8v36kl5swhs9-ruby2.5.3-fusuma-0.10.2
patching script interpreter paths in /nix/store/yqphkpvgw9hrlbv32i3y8v36kl5swhs9-ruby2.5.3-fusuma-0.10.2
/nix/store/yqphkpvgw9hrlbv32i3y8v36kl5swhs9-ruby2.5.3-fusuma-0.10.2/lib/ruby/gems/2.5.0/gems/fusuma-0.10.2/exe/fusuma: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/bin/ruby"
/nix/store/yqphkpvgw9hrlbv32i3y8v36kl5swhs9-ruby2.5.3-fusuma-0.10.2/lib/ruby/gems/2.5.0/gems/fusuma-0.10.2/bin/setup: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/yqphkpvgw9hrlbv32i3y8v36kl5swhs9-ruby2.5.3-fusuma-0.10.2/lib/ruby/gems/2.5.0/gems/fusuma-0.10.2/bin/console: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/imzyjwl9yv28h02zwsjpdsb2va7s8rqk-ruby-2.5.3/bin/ruby"
checking for references to /build in /nix/store/yqphkpvgw9hrlbv32i3y8v36kl5swhs9-ruby2.5.3-fusuma-0.10.2...
building '/nix/store/b83z495ydmdcwvcdx3x7xlzvcran5fjr-fusuma-0.10.2.drv'...
created 9 symlinks in user environment
building '/nix/store/3y0cs5628fk06fcdhb0s32xw2q2vjzir-fusuma-0.10.2.drv'...
/nix/store/9pf124lhvd10iipgrd1s8dfg903xly5v-fusuma-0.10.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: fusuma

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/jxkc45y87y9k66zsr8c793i5ahcd2g65-ruby2.5.3-fusuma-0.10.2
patching script interpreter paths in /nix/store/jxkc45y87y9k66zsr8c793i5ahcd2g65-ruby2.5.3-fusuma-0.10.2
/nix/store/jxkc45y87y9k66zsr8c793i5ahcd2g65-ruby2.5.3-fusuma-0.10.2/lib/ruby/gems/2.5.0/gems/fusuma-0.10.2/exe/fusuma: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3/bin/ruby"
/nix/store/jxkc45y87y9k66zsr8c793i5ahcd2g65-ruby2.5.3-fusuma-0.10.2/lib/ruby/gems/2.5.0/gems/fusuma-0.10.2/bin/setup: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
/nix/store/jxkc45y87y9k66zsr8c793i5ahcd2g65-ruby2.5.3-fusuma-0.10.2/lib/ruby/gems/2.5.0/gems/fusuma-0.10.2/bin/console: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/51sgjlq650kkxs7iz2wcz33lx74awn57-ruby-2.5.3/bin/ruby"
checking for references to /build in /nix/store/jxkc45y87y9k66zsr8c793i5ahcd2g65-ruby2.5.3-fusuma-0.10.2...
building '/nix/store/fhr6hy46y355rj2v2r94d7kxj0irfy5x-fusuma-0.10.2.drv'...
created 9 symlinks in user environment
building '/nix/store/3cgf9cnm0xymyaw2nfjyc6hj247zy63a-fusuma-0.10.2.drv'...
/nix/store/mjg68q8j7kp2k4hw06lqfjan953iqwhy-fusuma-0.10.2

@worldofpeace
Copy link
Contributor

Seems to build.

However, this makes me think this might need a nixos module.
Also a systemd service might be useful

@jfrankenau
Copy link
Member Author

Yes, I’ve been thinking about that and will create a module when I find the time. For now I am simply using my DE for autostarting it.

@worldofpeace
Copy link
Contributor

For now I am simply using my DE for autostarting it.

@jfrankenau You're confirming that it works?

I'm then assuming you did sudo gpasswd -a $USER input manually then.

@jfrankenau
Copy link
Member Author

Yes, I did and it works fine.

worldofpeace
worldofpeace approved these changes Nov 15, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

cc @Mic92 (merger)

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 18, 2018

Ok merging the package then. @jfrankenau please open a new PR once you got the time to write a service module to go with it :)

@c0bw3b c0bw3b merged commit ab06622 into NixOS:master Nov 18, 2018
@jfrankenau jfrankenau deleted the init-fusuma branch November 23, 2018 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jfrankenau @worldofpeace @GrahamcOfBorg @c0bw3b