Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uftrace: 0.9 -> 0.9.1 #50228

Merged
merged 2 commits into from Nov 11, 2018
Merged

uftrace: 0.9 -> 0.9.1 #50228

merged 2 commits into from Nov 11, 2018

Conversation

nthorne
Copy link
Contributor

@nthorne nthorne commented Nov 11, 2018

Motivation for this change

Update uftrace to latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member

timokau commented Nov 11, 2018

@GrahamcOfBorg build uftrace

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: uftrace

Partial log (click to expand)

shrinking /nix/store/4ymarzfgbaycbphbdiywrgjf8x04sabf-uftrace-0.9.1/lib/libmcount-single.so
shrinking /nix/store/4ymarzfgbaycbphbdiywrgjf8x04sabf-uftrace-0.9.1/lib/libmcount-fast.so
shrinking /nix/store/4ymarzfgbaycbphbdiywrgjf8x04sabf-uftrace-0.9.1/lib/libmcount-nop.so
shrinking /nix/store/4ymarzfgbaycbphbdiywrgjf8x04sabf-uftrace-0.9.1/lib/libmcount.so
shrinking /nix/store/4ymarzfgbaycbphbdiywrgjf8x04sabf-uftrace-0.9.1/bin/uftrace
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4ymarzfgbaycbphbdiywrgjf8x04sabf-uftrace-0.9.1/lib  /nix/store/4ymarzfgbaycbphbdiywrgjf8x04sabf-uftrace-0.9.1/bin
patching script interpreter paths in /nix/store/4ymarzfgbaycbphbdiywrgjf8x04sabf-uftrace-0.9.1
checking for references to /build in /nix/store/4ymarzfgbaycbphbdiywrgjf8x04sabf-uftrace-0.9.1...
/nix/store/4ymarzfgbaycbphbdiywrgjf8x04sabf-uftrace-0.9.1

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: uftrace

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

timokau
timokau requested changes Nov 11, 2018
View reviewed changes
pkgs/development/tools/uftrace/default.nix Outdated

src = fetchFromGitHub {
owner = "namhyung";
repo = "uftrace";
rev = "f0fed0b24a9727ffed04673b62f66baad21a1f99";
sha256 = "0rn2xwd87qy5ihn5zq9pwq8cs1vfmcqqz0wl70wskkgp2ccsd9x8";
rev = "5766876f56b1bfcad76370d20f9f8b002a01e57d";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use rev = "v${version}" here. Manually updating the rev every update is redundant and error-prone since upstream properly tags their releases and rev understands tags.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good tip. Thanks, @timokau!

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: uftrace

Partial log (click to expand)

shrinking /nix/store/a0f9zz2b5604cz08a9r04gjh6kjg96rj-uftrace-0.9.1/lib/libmcount-nop.so
shrinking /nix/store/a0f9zz2b5604cz08a9r04gjh6kjg96rj-uftrace-0.9.1/lib/libmcount-fast-single.so
shrinking /nix/store/a0f9zz2b5604cz08a9r04gjh6kjg96rj-uftrace-0.9.1/lib/libmcount.so
shrinking /nix/store/a0f9zz2b5604cz08a9r04gjh6kjg96rj-uftrace-0.9.1/lib/libmcount-fast.so
shrinking /nix/store/a0f9zz2b5604cz08a9r04gjh6kjg96rj-uftrace-0.9.1/bin/uftrace
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/a0f9zz2b5604cz08a9r04gjh6kjg96rj-uftrace-0.9.1/lib  /nix/store/a0f9zz2b5604cz08a9r04gjh6kjg96rj-uftrace-0.9.1/bin
patching script interpreter paths in /nix/store/a0f9zz2b5604cz08a9r04gjh6kjg96rj-uftrace-0.9.1
checking for references to /build in /nix/store/a0f9zz2b5604cz08a9r04gjh6kjg96rj-uftrace-0.9.1...
/nix/store/a0f9zz2b5604cz08a9r04gjh6kjg96rj-uftrace-0.9.1

@timokau
Copy link
Member

timokau commented Nov 11, 2018

@GrahamcOfBorg build uftrace

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: uftrace

Partial log (click to expand)

/nix/store/4ymarzfgbaycbphbdiywrgjf8x04sabf-uftrace-0.9.1

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: uftrace

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: uftrace

Partial log (click to expand)

/nix/store/a0f9zz2b5604cz08a9r04gjh6kjg96rj-uftrace-0.9.1

@timokau
Copy link
Member

timokau commented Nov 11, 2018

Thank you :)

@timokau timokau merged commit 0a7d20e into NixOS:master Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nthorne @timokau @GrahamcOfBorg