Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: 0.81.5 -> 0.82.0 #50166

Merged
merged 5 commits into from Nov 12, 2018
Merged

home-assistant: 0.81.5 -> 0.82.0 #50166

merged 5 commits into from Nov 12, 2018

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Nov 10, 2018 •
edited

Motivation for this change

This is work in progress because the test does not run successfully. I don't have access to a real-world instance of Home Assistant right now so I'm still putting this online for review.
Found out the problem: I had to pin pyotp.

python.pkgs.protobuf3_1 needed to be removed because parse-requirements.py would not be able tell which version to use. That's also the reason why I improved the assert statement.

I cherry-picked 0020991 because I want to use fetchPypi.override. Should I use git cherry-pick -x for that?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda force-pushed the home-assistant-0.82 branch 3 times, most recently from 3819c7a to dfde894 Compare November 10, 2018 13:59
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: home-assistant

Partial log (click to expand)

tests/components/test_init.py .................                          [ 87%]
tests/components/test_introduction.py .                                  [ 88%]
tests/components/test_logger.py ......                                   [ 90%]
tests/components/test_script.py .....                                    [ 91%]
tests/components/test_shell_command.py ........                          [ 94%]
tests/components/test_system_log.py ................                     [100%]

========================= 297 passed in 14.10 seconds ==========================
pytestcachePhase
/nix/store/h7igjbxhvxv7v3gmrx4gnnl9g2h5h01c-homeassistant-0.82.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: home-assistant

Partial log (click to expand)

tests/components/test_init.py .................                          [ 87%]
tests/components/test_introduction.py .                                  [ 88%]
tests/components/test_logger.py ......                                   [ 90%]
tests/components/test_script.py .....                                    [ 91%]
tests/components/test_shell_command.py ........                          [ 94%]
tests/components/test_system_log.py ................                     [100%]

========================= 297 passed in 15.01 seconds ==========================
pytestcachePhase
/nix/store/hhd61vk7w1zsbnib8zy5aja9hdvn7mh9-homeassistant-0.82.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: home-assistant

Partial log (click to expand)

tests/components/test_init.py .................                          [ 87%]
tests/components/test_introduction.py .                                  [ 88%]
tests/components/test_logger.py ......                                   [ 90%]
tests/components/test_script.py .....                                    [ 91%]
tests/components/test_shell_command.py ........                          [ 94%]
tests/components/test_system_log.py ................                     [100%]

========================= 297 passed in 25.69 seconds ==========================
pytestcachePhase
/nix/store/6gxd5hmqlmslp81x2zg77w6wbi09f41b-homeassistant-0.82.0

@dotlambda
Copy link
Member Author

dotlambda commented Nov 10, 2018 •
edited

I think we should probably add the openzwave forks created by Home Assistant: home-assistant/core#18268.
I'll try packaging them once PyPI is up again.
Does anyone know of a NixOS user who's running Home Assistant to control ZWave devices and might be able to test this?
cc @etu

@dotlambda
Copy link
Member Author

I have now packaged their fork of the Python library but that lead to quite a lot of code duplication. We should either

  • use overridePythonAttrs or
  • remove the now unused python.pkgs.python_openzwave.

What's your opinion?

Also, should we simply use their fork's source code for our openzwave package? See OpenZWave/open-zwave@master...home-assistant:hass for the difference.

@etu
Copy link
Contributor

etu commented Nov 11, 2018

Does anyone know of a NixOS user who's running Home Assistant to control ZWave devices and might be able to test this?

I'm probably able to test it whenever you have it packaged up. My box that I run hass on with my openzwave is a raspberry though so it may take some time to build things if it needs building because I don't have any hydra or nixops set up for that yet.

My system is running on 18.09 stable, but it should be easy to test without changing too much since the modules supports specifying which hass-package to use.

@dotlambda
Copy link
Member Author

You can test it right now and it should work fine. I'll probably switch to Home Assistant's source for OpenZWave but that shouldn't change much.

@etu
Copy link
Contributor

etu commented Nov 11, 2018

You can test it right now and it should work fine. I'll probably switch to Home Assistant's source for OpenZWave but that shouldn't change much.

@dotlambda Oh, yeah. I'm building it on my raspberry at the moment. I'll report back whenever it's done.

@etu
Copy link
Contributor

etu commented Nov 12, 2018

@dotlambda Hey, I have 0.82.0 running on my raspberry now from your branch. It seems to be working perfectly fine with my ZWave devices 👍

Robert Schütz and others added 5 commits November 12, 2018 11:10
python.pkgs.protobuf3_1: drop
b230ad0 
Using the specific version of protobuf can be achieved by a simple
`python.pkgs.protobuf.override { protobuf = protobuf3_1; }`.
@costrouc
pythonPackages.ruamel_yaml: refactor move to python-modules
484a5c6
python3.pkgs.homeassistant-pyozw: init at 0.1.0
92148ea
openzwave: 2018-04-04 -> 2018-11-04
e58c502 
Switch to Home Assistant's source
(https://github.com/home-assistant/open-zwave/tree/hass)
because openzwave is only used in combination with Home Assistant afaik.
home-assistant: 0.81.5 -> 0.82.0
dbceff8
@dotlambda dotlambda merged commit b9494ac into NixOS:master Nov 12, 2018
@dotlambda dotlambda deleted the home-assistant-0.82 branch March 21, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @GrahamcOfBorg @etu @costrouc