Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spaceship-prompt: init at 3.7.1 #50177

Merged
merged 2 commits into from Nov 11, 2018
Merged

spaceship-prompt: init at 3.7.1 #50177

merged 2 commits into from Nov 11, 2018

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Nov 10, 2018 •
edited

Motivation for this change

ZSH prompt, can be used with ohMyZsh.customPkgs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@infinisil infinisil merged commit 0f21bec into NixOS:master Nov 11, 2018
eadwu
eadwu reviewed Nov 11, 2018
View reviewed changes
pkgs/shells/zsh/spaceship-prompt/default.nix

meta = with stdenv.lib; {
description = "Zsh prompt for Astronauts";
homepage = https://github.com/halfo/lambda-mod-zsh-theme/;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the correct url? Sorry for the post merge question.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good point, I didn't notice that. @nyanloutre Would you mind submitting another PR to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil left review comments

@eadwu eadwu eadwu left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nyanloutre @infinisil @eadwu @GrahamcOfBorg