Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitea: 1.5.2 -> 1.5.3 #50229

Merged
merged 1 commit into from Nov 11, 2018
Merged

gitea: 1.5.2 -> 1.5.3 #50229

merged 1 commit into from Nov 11, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Nov 11, 2018

Motivation for this change

Changelog: https://github.com/go-gitea/gitea/releases/tag/v1.5.3

This is a security related release and should be backported.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@etu
Copy link
Contributor Author

etu commented Nov 11, 2018

@GrahamcOfBorg test gitea

@GrahamcOfBorg
Copy link

Success on x86_64-linux

Attempted: tests.gitea

No partial log is available.

@GrahamcOfBorg
Copy link

Success on aarch64-linux

Attempted: tests.gitea

No partial log is available.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitea

Partial log (click to expand)

checking for references to /build in /nix/store/k7gkalk2wsz2nzw2fnl1phyrvj5zl34k-gitea-1.5.3-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/47mwyndls6raivhkywr5sixv005zlpgn-gitea-1.5.3
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/47mwyndls6raivhkywr5sixv005zlpgn-gitea-1.5.3
checking for references to /build in /nix/store/47mwyndls6raivhkywr5sixv005zlpgn-gitea-1.5.3...
shrinking RPATHs of ELF executables and libraries in /nix/store/i783sy4xzgkr1c7cd6xdrvnlbl16n9h7-gitea-1.5.3-data
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/i783sy4xzgkr1c7cd6xdrvnlbl16n9h7-gitea-1.5.3-data
checking for references to /build in /nix/store/i783sy4xzgkr1c7cd6xdrvnlbl16n9h7-gitea-1.5.3-data...
/nix/store/k7gkalk2wsz2nzw2fnl1phyrvj5zl34k-gitea-1.5.3-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gitea

Partial log (click to expand)

installing
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/5dxlxpgjwqd4vny7hw7m4k8py762wqda-gitea-1.5.3-bin/bin
patching script interpreter paths in /nix/store/5dxlxpgjwqd4vny7hw7m4k8py762wqda-gitea-1.5.3-bin
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/lfkhr3p2f0y4ljrzwmvwh118c2nynxrl-gitea-1.5.3
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/2kqbbipjcnqslriz9ma9gihxz8jg4x2z-gitea-1.5.3-data
/nix/store/5dxlxpgjwqd4vny7hw7m4k8py762wqda-gitea-1.5.3-bin

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: gitea

Partial log (click to expand)

        /nix/store/2jz7z8f6xnx1cv8vr6fmf21y96fg86ri-go-1.11/share/go/src/runtime/asm_arm64.s:1114 +0x4
code.gitea.io/gitea/vendor/github.com/blevesearch/bleve/document
code.gitea.io/gitea/vendor/github.com/couchbase/vellum
code.gitea.io/gitea/vendor/github.com/blevesearch/bleve/index
code.gitea.io/gitea/vendor/github.com/blevesearch/bleve/search
code.gitea.io/gitea/vendor/github.com/blevesearch/bleve/registry
code.gitea.io/gitea/vendor/github.com/blevesearch/bleve/search/searcher
code.gitea.io/gitea/vendor/github.com/blevesearch/bleve/search/query
builder for '/nix/store/qj0dqp2i8z117awli5n42fymbylhj00v-gitea-1.5.3.drv' failed with exit code 41
error: build of '/nix/store/qj0dqp2i8z117awli5n42fymbylhj00v-gitea-1.5.3.drv' failed

@dotlambda dotlambda added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 11, 2018
@dotlambda
Copy link
Member

This seems to break gitea on aarch64, which was working before: https://hydra.nixos.org/job/nixpkgs/trunk/gitea.aarch64-linux

@GrahamcOfBorg build gitea

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gitea

Partial log (click to expand)

/nix/store/5dxlxpgjwqd4vny7hw7m4k8py762wqda-gitea-1.5.3-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitea

Partial log (click to expand)

checking for references to /build in /nix/store/k7gkalk2wsz2nzw2fnl1phyrvj5zl34k-gitea-1.5.3-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/47mwyndls6raivhkywr5sixv005zlpgn-gitea-1.5.3
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/47mwyndls6raivhkywr5sixv005zlpgn-gitea-1.5.3
checking for references to /build in /nix/store/47mwyndls6raivhkywr5sixv005zlpgn-gitea-1.5.3...
shrinking RPATHs of ELF executables and libraries in /nix/store/i783sy4xzgkr1c7cd6xdrvnlbl16n9h7-gitea-1.5.3-data
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/i783sy4xzgkr1c7cd6xdrvnlbl16n9h7-gitea-1.5.3-data
checking for references to /build in /nix/store/i783sy4xzgkr1c7cd6xdrvnlbl16n9h7-gitea-1.5.3-data...
/nix/store/k7gkalk2wsz2nzw2fnl1phyrvj5zl34k-gitea-1.5.3-bin

@etu
Copy link
Contributor Author

etu commented Nov 11, 2018

@dotlambda Yeah, the build of gitea seems to be a bit unstable on aarch64 overall. If you look at the history there on the link 1.5.2 seemed to fail 3 times before success as well...

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: gitea

Partial log (click to expand)

code.gitea.io/gitea/modules/cache
code.gitea.io/gitea/modules/options
code.gitea.io/gitea/modules/validation
code.gitea.io/gitea/modules/highlight
code.gitea.io/gitea/modules/base
code.gitea.io/gitea/modules/mailer
code.gitea.io/gitea/modules/markup
code.gitea.io/gitea/modules/markup/markdown
builder for '/nix/store/qj0dqp2i8z117awli5n42fymbylhj00v-gitea-1.5.3.drv' failed with exit code 43
error: build of '/nix/store/qj0dqp2i8z117awli5n42fymbylhj00v-gitea-1.5.3.drv' failed

@etu
Copy link
Contributor Author

etu commented Nov 11, 2018

Nvm the previous comment, the builds on hydra seems to have been running for 0 seconds...

But from the failed build log above:

# code.gitea.io/gitea/vendor/gopkg.in/editorconfig/editorconfig-core-go.v1
runtime: failed to create new OS thread (have 2 already; errno=11)
runtime: may need to increase max user processes (ulimit -u)
fatal error: newosproc

Maybe that's only an issue while building with the bot?

@dotlambda
Copy link
Member

It was aborted before. That doesn't mean gitea failed to build. It was probably some dependency's job that consumed too much resources so it was aborted.

@dotlambda
Copy link
Member

Maybe that's only an issue while building with the bot?

I'll try building it on my Raspberry Pi.

@dotlambda
Copy link
Member

Works fine on my Raspberri Pi 3, so I'll just merge.

@dotlambda dotlambda merged commit 090bd93 into NixOS:master Nov 11, 2018
dotlambda pushed a commit that referenced this pull request Nov 11, 2018
@etu
gitea: 1.5.2 -> 1.5.3 (#50229)
ee7b0db 
Changelog: https://github.com/go-gitea/gitea/releases/tag/v1.5.3
(cherry picked from commit 090bd93)
@dotlambda
Copy link
Member

Cherry picked in ee7b0db.

@etu etu deleted the upgrade_gitea branch November 11, 2018 17:47
@etu
Copy link
Contributor Author

etu commented Nov 11, 2018

@grahamc Any insight in this issue above?

@markuskowa markuskowa mentioned this pull request Dec 5, 2018
Merged
10 tasks
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@etu @GrahamcOfBorg @dotlambda @samueldr