Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qgroundcontrol: fixes #49870 #50232

Merged
merged 1 commit into from Nov 14, 2018
Merged

qgroundcontrol: fixes #49870 #50232

merged 1 commit into from Nov 14, 2018

Conversation

wucke13
Copy link
Contributor

@wucke13 wucke13 commented Nov 11, 2018 •
edited

Motivation for this change

The .desktop referenced a non existent script to run QGroundControl. This commits adds a sed command, which replaces the non existent script by the name of the QGroundControl binary in the relevant .desktop file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

FRidh
FRidh requested changes Nov 11, 2018
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix commit message and title to describe respectively what the change is about and what derivation is being modified.

@wucke13 wucke13 changed the title fixes #49870 qgroundcontrol: fixes #49870 Nov 11, 2018
@wucke13
qgroundcontrol: fixes NixOS#49870
c26b42b 
The `.desktop` referenced a non existent script to run `QGroundControl`. This commits adds a `sed` command, which replaces the non existent script by the name of the `QGroundControl` binary in the relevant `.desktop` file.
@Mic92
Copy link
Member

Mic92 commented Nov 14, 2018

Does this also affect the 18.09 release?

@Mic92 Mic92 merged commit 987bd62 into NixOS:master Nov 14, 2018
@worldofpeace
Copy link
Contributor

@Mic92 I checked the output of this from 18.09 and this is needed.

@Mic92
Copy link
Member

Mic92 commented Nov 14, 2018

backported: bedbba6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wucke13 @Mic92 @worldofpeace @FRidh @GrahamcOfBorg