Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated sources of security information; removed a dead key #252

Merged
merged 1 commit into from Nov 26, 2018
Merged

updated sources of security information; removed a dead key #252

merged 1 commit into from Nov 26, 2018

Conversation

ekalosak
Copy link
Contributor

Resolves issue 251 re: outdated security page.

@ekalosak ekalosak mentioned this pull request Nov 15, 2018
Closed
@domenkozar
Copy link
Member

cc @rbvermaa

fpletz
fpletz approved these changes Nov 15, 2018
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@ekalosak
Copy link
Contributor Author

Out of curiosity, what's the process for merging PRs after review?

@domenkozar
Copy link
Member

Let's wait for Rob a couple of days and then merge :)

@Ekleog
Copy link
Member

Ekleog commented Nov 26, 2018

@domenkozar Is 10 days “a couple of days”? :)

@domenkozar domenkozar merged commit 3587643 into NixOS:master Nov 26, 2018
@ekalosak ekalosak deleted the ekalosak/fix-dead-security-links branch December 4, 2018 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@Ekleog Ekleog Ekleog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ekalosak @domenkozar @Ekleog @fpletz