firefoxen: remove unused gstreamer dependencies #50373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox and, by extension, Tor browser don't support gstreamer any more, this removes what are effectively unused dependencies. https://bugzilla.mozilla.org/show_bug.cgi?id=1234092 "Remove gstreamer support"
andir
reviewed
Nov 15, 2018
| @@ -19,7 +19,7 @@ | |||
|
|
|||
| , alsaSupport ? stdenv.isLinux, alsaLib | |||
| , pulseaudioSupport ? stdenv.isLinux, libpulseaudio | |||
| , ffmpegSupport ? true, gstreamer, gst-plugins-base | |||
| , ffmpegSupport ? true | |||
There was a problem hiding this comment.
Shouldn't this flag be removed entirely? I am wondering because how is ffmpeg pulled in if enabled?
The tor-browser-bundle has an explicit reference to ffmpeg.
There was a problem hiding this comment.
AFAICT it bundles the needed headers and the libraries are loaded at runtime via dlopen so the package isn't needed at build time. For runtime the libraries are added to the LD_LIBRARY_PATH in the wrapper (wrapper.nix next to this file) based on whether the browser that is being wrapped was built with ffmpeg support.
|
LGTM |
|
Thanks! 👍 @pbogdan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox and, by extension, Tor browser don't support gstreamer any more, this
removes what are effectively unused dependencies.
https://bugzilla.mozilla.org/show_bug.cgi?id=1234092 "Remove gstreamer support"
Motivation for this change
Working towards #22372 and #39975 (removal of old gstreamer and ffmpeg versions).
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)Built
firefox,firefox-esr,tor-browser-bundleandtor-browser-bundle-binand verified media playback works in all (withmediaSupportenabled for the tor browsers)./cc @joachifm @oxij for the tor browser changes
Not sure who, if anyone, to ping for the Firefox changes.