Skip to content

[staging] nss, libpng updates #50374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2018
Merged

[staging] nss, libpng updates #50374

merged 2 commits into from
Nov 16, 2018
+7 −7

Conversation

andir
Copy link
Member

@andir andir commented Nov 14, 2018 •
edited
Loading

Motivation for this change

I am trying to get all the dependencies for the next Firefox releasesup to date early this time.

These changes are the ones that I could identify & bump so far.

I did try these changes on top of master and they did compile fine. I am still building them based on the staging branch but do not expect breakage.

At some point we should probably port them back to 18.09 so we can ship the FFX update there as well..

@andir andir requested review from vcunat and dtzWill November 14, 2018 23:45
@dtzWill
Copy link
Member

dtzWill commented Nov 15, 2018

sqlite3 after 3.25 causes test failures in sqlalchemy (for us anyway?), it's been blocking updating it so far-- see #46852 .

@andir
Copy link
Member Author

andir commented Nov 15, 2018

Awwhh right, I remember running into that a while ago :/ Should have searched for that.. I'll drop sqlite from this PR.

@andir andir changed the title [staging] nss, libpng, sqlite updates [staging] nss, libpng updates Nov 15, 2018
@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: libpng, nss, sqlite

Partial log (click to expand)

cannot build derivation '/nix/store/264gg0p206pdm25lgkad54bj5h52qk5j-nghttp2-1.34.0.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/mnhfp91ickv9dm8w023vkhfdyk4s6k64-curl-7.62.0.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/lwb16pnmn4ghd8v3yf29ps5g8xl78x35-libpng-1.6.35-apng.patch.gz.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/wj72jswq68r9bqmc69i1y2xa4shi72fp-libpng-1.6.35.tar.xz.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/ncz7dshn08hgd5gkmyp50caz4vc364v4-nss-3.40.tar.gz.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/swgg8r60kb2jcyfyhyp1n0qap42w584l-sqlite-autoconf-3250300.tar.gz.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/ziwxm3x0x8ib7802skwspsxapfcy84gx-libpng-apng-1.6.35.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/dks43p27bcsgpgp8pyayp7d16z73rxwk-sqlite-3.25.3.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/94g7zpdd6xakad4gzcp19w29sj3l4lrc-nss-3.40.drv': 6 dependencies couldn't be built
error: build of '/nix/store/94g7zpdd6xakad4gzcp19w29sj3l4lrc-nss-3.40.drv', '/nix/store/dks43p27bcsgpgp8pyayp7d16z73rxwk-sqlite-3.25.3.drv', '/nix/store/ziwxm3x0x8ib7802skwspsxapfcy84gx-libpng-apng-1.6.35.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libpng, nss

Partial log (click to expand)

moduleSpec configdir='' certPrefix='' keyPrefix='' secmod='' flags=noCertDB, noModDB
Generate a DSA key pair ...
Moving /nix/store/kdn2yv4dab95w66a5di2ncjwv5bl9sv3-nss-3.40/bin to /nix/store/lnw3d7fpj40mpax93qdmmwl8srayq99c-nss-3.40-tools/bin
rmdir: failed to remove '/nix/store/kdn2yv4dab95w66a5di2ncjwv5bl9sv3-nss-3.40': Directory not empty
Moving /nix/store/lnw3d7fpj40mpax93qdmmwl8srayq99c-nss-3.40-tools/bin/nss-config to /nix/store/6yhdqfyw70bj2jm8g5jp2xlgxblalw06-nss-3.40-dev/bin/nss-config
rmdir: failed to remove '/nix/store/lnw3d7fpj40mpax93qdmmwl8srayq99c-nss-3.40-tools/bin': Directory not empty
Moving /nix/store/kdn2yv4dab95w66a5di2ncjwv5bl9sv3-nss-3.40/lib/libcrmf.a to /nix/store/6yhdqfyw70bj2jm8g5jp2xlgxblalw06-nss-3.40-dev/lib/libcrmf.a
rmdir: failed to remove '/nix/store/kdn2yv4dab95w66a5di2ncjwv5bl9sv3-nss-3.40/lib': Directory not empty
/nix/store/g8n7drgbnhfxbbjphkavbkzgb63yww79-libpng-apng-1.6.35
/nix/store/kdn2yv4dab95w66a5di2ncjwv5bl9sv3-nss-3.40

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libpng, nss, sqlite

Partial log (click to expand)

Generate a DSA key pair ...
Moving /nix/store/bjlyfflrqy1ygw2p6b5l8n7ycf8a07f8-nss-3.40/bin to /nix/store/48i9i7ra4d1h5w47jwcb1rigz1znbak3-nss-3.40-tools/bin
rmdir: failed to remove '/nix/store/bjlyfflrqy1ygw2p6b5l8n7ycf8a07f8-nss-3.40': Directory not empty
Moving /nix/store/48i9i7ra4d1h5w47jwcb1rigz1znbak3-nss-3.40-tools/bin/nss-config to /nix/store/88bz5fvdny9kpflswsm54cqx7j60vnm9-nss-3.40-dev/bin/nss-config
rmdir: failed to remove '/nix/store/48i9i7ra4d1h5w47jwcb1rigz1znbak3-nss-3.40-tools/bin': Directory not empty
Moving /nix/store/bjlyfflrqy1ygw2p6b5l8n7ycf8a07f8-nss-3.40/lib/libcrmf.a to /nix/store/88bz5fvdny9kpflswsm54cqx7j60vnm9-nss-3.40-dev/lib/libcrmf.a
rmdir: failed to remove '/nix/store/bjlyfflrqy1ygw2p6b5l8n7ycf8a07f8-nss-3.40/lib': Directory not empty
/nix/store/g8n7drgbnhfxbbjphkavbkzgb63yww79-libpng-apng-1.6.35
/nix/store/bjlyfflrqy1ygw2p6b5l8n7ycf8a07f8-nss-3.40
/nix/store/3zylldmwy2sn3yfdcgb90pmrhpjds6m3-sqlite-3.25.3-bin

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: libpng, nss, sqlite

Partial log (click to expand)

cannot build derivation '/nix/store/9lis8zrlqdni7gl2ynfxqa3xbmqiamhd-apple-framework-IOKit.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/1182d00m5j496knh6plnvyiyf7wd7n0c-apple-framework-NetFS.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/c04sn8jn200ppdqnd014mhlk76gxr9d9-apple-framework-CoreAudio.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/h1fhr2723pz03x6gdy33i86dkjfjqc8f-apple-framework-DiskArbitration.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/ggkwlays7017aqk20nb038mbpqjslbz3-apple-framework-Security.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/7wcnxab974524q2ircvjqaxd0p4hy3jl-apple-framework-ServiceManagement.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/gn8p691rp9i21d7nwp5y14pjra6y057p-apple-framework-CoreServices.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/w5p4ay6yb4v6h3i21gdbw4p42h5pan7p-nspr-4.20.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/zp6p458wikmrxxl7z5rvj6zjya43zc5r-nss-3.40.drv': 6 dependencies couldn't be built
error: build of '/nix/store/6i79kikfizw7a60sw0gjqwgraqia3c2a-sqlite-3.25.3.drv', '/nix/store/y98z2h8nq7xx8z6l9pjac80gdq3mrn5z-libpng-apng-1.6.35.drv', '/nix/store/zp6p458wikmrxxl7z5rvj6zjya43zc5r-nss-3.40.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: libpng, nss

Partial log (click to expand)

cannot build derivation '/nix/store/qbxr7li637dwga9hjw7lcsqqnqjz4c45-libkrb5-1.15.2.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/ykjnsrm0khg9xwwaigqx14jr9za7hpwd-libssh2-1.8.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/264gg0p206pdm25lgkad54bj5h52qk5j-nghttp2-1.34.0.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/mnhfp91ickv9dm8w023vkhfdyk4s6k64-curl-7.62.0.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/lwb16pnmn4ghd8v3yf29ps5g8xl78x35-libpng-1.6.35-apng.patch.gz.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/wj72jswq68r9bqmc69i1y2xa4shi72fp-libpng-1.6.35.tar.xz.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/ncz7dshn08hgd5gkmyp50caz4vc364v4-nss-3.40.tar.gz.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/ziwxm3x0x8ib7802skwspsxapfcy84gx-libpng-apng-1.6.35.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/7vchn0jxqvb3n3sgzphz8s1fpbiki2kl-nss-3.40.drv': 6 dependencies couldn't be built
error: build of '/nix/store/7vchn0jxqvb3n3sgzphz8s1fpbiki2kl-nss-3.40.drv', '/nix/store/ziwxm3x0x8ib7802skwspsxapfcy84gx-libpng-apng-1.6.35.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: libpng, nss

Partial log (click to expand)

cannot build derivation '/nix/store/k448i7ghardzd4mbc04jsmjmh40hqgkw-apple-framework-IOKit.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/2dbrihg7a9q8ba9fr7npykinw1b8vahj-apple-framework-NetFS.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/jllgqm4lfk2xwwgbiv3m8ifsvh1afnqi-apple-framework-CoreAudio.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/xc9mcg9621lafjblygbajyn4v1hxrkc8-apple-framework-DiskArbitration.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/0kxl4fs1ln3bdvv3j1cvn0ph9swibg7d-apple-framework-Security.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/1im44y1mkxifk7zdb81z1s01k6vwgwsn-apple-framework-ServiceManagement.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/dxv6ha4sf9yv71y4xshs8i5mk3gikc31-apple-framework-CoreServices.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/xb9cm33z1fphdkx99clm18ybhk8f3q38-nspr-4.20.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/4rwlg5d8gjmd7418mp861x6dzsfwyibh-nss-3.40.drv': 6 dependencies couldn't be built
error: build of '/nix/store/4rwlg5d8gjmd7418mp861x6dzsfwyibh-nss-3.40.drv', '/nix/store/y98z2h8nq7xx8z6l9pjac80gdq3mrn5z-libpng-apng-1.6.35.drv' failed

vcunat
vcunat approved these changes Nov 15, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both seem quite safe to me, even for 18.09. Release notes: NSS, libpng.

@vcunat
Copy link
Member

vcunat commented Nov 15, 2018 •
edited
Loading

These two (and sqlite) will be all needed for FF 64 in about four weeks from now? If so, I expect we can delay cherry-picking them to 18.09 by a couple weeks (to get even more confidence).

Encrypted SNI support 🎉 We might actually get reasonable DNS/hostname privacy in practice.

@andir
Copy link
Member Author

andir commented Nov 15, 2018 via email

@andir andir merged commit e15bac8 into NixOS:staging Nov 16, 2018
@andir andir deleted the ffx-staging branch November 16, 2018 16:47
@andir andir mentioned this pull request Nov 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat

@dtzWill dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andir @dtzWill @GrahamcOfBorg @vcunat