waifu2x-converter-cpp: init at 5.2.1 #50398
Closed
+34
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
8.has: package (new)
|
@GrahamcOfBorg build waifu2x-converter-cpp |
|
Success on x86_64-linux (full log) Attempted: waifu2x-converter-cpp Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: waifu2x-converter-cpp Partial log (click to expand)
|
aanderse
requested changes
Apr 9, 2019
| { stdenv, fetchFromGitHub, cmake, pkgconfig, opencv3, opencl-headers, | ||
| cudaSupport ? false , cudatoolkit ? null }: | ||
| stdenv.mkDerivation rec { | ||
| name = "${pname}-${version}"; |
There was a problem hiding this comment.
No longer required as pname and version alone are sufficient.
|
|
||
| preConfigure = '' | ||
| mkdir -p $out | ||
| cp -r models_rgb $out/ |
There was a problem hiding this comment.
According to https://github.com/DeadSix27/waifu2x-converter-cpp/blob/master/BUILDING.md it looks like this step is only required on MacOS/OSX?
Also, why is this in preConfigure instead of postInstall?
| stdenv.mkDerivation rec { | ||
| name = "${pname}-${version}"; | ||
| pname = "waifu2x-converter-cpp"; | ||
| version = "5.2.1"; |
There was a problem hiding this comment.
Please bump to most recent release (currently 5.2.4).
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds waifu2x-converter-cpp, an anime image superresolution tool.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)