Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waifu2x-converter-cpp: init at 5.2.1 #50398

Closed
wants to merge 1 commit into from
Closed

waifu2x-converter-cpp: init at 5.2.1 #50398

wants to merge 1 commit into from

Conversation

mt-caret
Copy link
Contributor

Motivation for this change

Adds waifu2x-converter-cpp, an anime image superresolution tool.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

@GrahamcOfBorg build waifu2x-converter-cpp

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: waifu2x-converter-cpp

Partial log (click to expand)

-- Installing: /nix/store/66ggwgfa2z5c1ahvhq0cf8id61q5gl44-waifu2x-converter-cpp-5.2.1/include/w2xconv.h
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/66ggwgfa2z5c1ahvhq0cf8id61q5gl44-waifu2x-converter-cpp-5.2.1
shrinking /nix/store/66ggwgfa2z5c1ahvhq0cf8id61q5gl44-waifu2x-converter-cpp-5.2.1/lib/libw2xc.so
shrinking /nix/store/66ggwgfa2z5c1ahvhq0cf8id61q5gl44-waifu2x-converter-cpp-5.2.1/bin/waifu2x-converter-cpp
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/66ggwgfa2z5c1ahvhq0cf8id61q5gl44-waifu2x-converter-cpp-5.2.1/lib  /nix/store/66ggwgfa2z5c1ahvhq0cf8id61q5gl44-waifu2x-converter-cpp-5.2.1/bin
patching script interpreter paths in /nix/store/66ggwgfa2z5c1ahvhq0cf8id61q5gl44-waifu2x-converter-cpp-5.2.1
checking for references to /build in /nix/store/66ggwgfa2z5c1ahvhq0cf8id61q5gl44-waifu2x-converter-cpp-5.2.1...
/nix/store/66ggwgfa2z5c1ahvhq0cf8id61q5gl44-waifu2x-converter-cpp-5.2.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: waifu2x-converter-cpp

Partial log (click to expand)

-- Installing: /nix/store/i37l6rd6836i27m9sjakqh9xwzxjfpib-waifu2x-converter-cpp-5.2.1/include/w2xconv.h
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/i37l6rd6836i27m9sjakqh9xwzxjfpib-waifu2x-converter-cpp-5.2.1
shrinking /nix/store/i37l6rd6836i27m9sjakqh9xwzxjfpib-waifu2x-converter-cpp-5.2.1/bin/waifu2x-converter-cpp
shrinking /nix/store/i37l6rd6836i27m9sjakqh9xwzxjfpib-waifu2x-converter-cpp-5.2.1/lib/libw2xc.so
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/i37l6rd6836i27m9sjakqh9xwzxjfpib-waifu2x-converter-cpp-5.2.1/lib  /nix/store/i37l6rd6836i27m9sjakqh9xwzxjfpib-waifu2x-converter-cpp-5.2.1/bin
patching script interpreter paths in /nix/store/i37l6rd6836i27m9sjakqh9xwzxjfpib-waifu2x-converter-cpp-5.2.1
checking for references to /build in /nix/store/i37l6rd6836i27m9sjakqh9xwzxjfpib-waifu2x-converter-cpp-5.2.1...
/nix/store/i37l6rd6836i27m9sjakqh9xwzxjfpib-waifu2x-converter-cpp-5.2.1

{ stdenv, fetchFromGitHub, cmake, pkgconfig, opencv3, opencl-headers,
cudaSupport ? false , cudatoolkit ? null }:
stdenv.mkDerivation rec {
name = "${pname}-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer required as pname and version alone are sufficient.


preConfigure = ''
mkdir -p $out
cp -r models_rgb $out/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://github.com/DeadSix27/waifu2x-converter-cpp/blob/master/BUILDING.md it looks like this step is only required on MacOS/OSX?

Also, why is this in preConfigure instead of postInstall?

stdenv.mkDerivation rec {
name = "${pname}-${version}";
pname = "waifu2x-converter-cpp";
version = "5.2.1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump to most recent release (currently 5.2.4).

@xzfc xzfc mentioned this pull request Apr 29, 2019
10 tasks
@c0bw3b c0bw3b closed this Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants