Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.vim-go: use the correct motion derivation for the dependency #50381

Merged
merged 2 commits into from Nov 15, 2018

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Nov 15, 2018

Motivation for this change

vimPlugins.vim-go was using the wrong motion package, see #49669 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @Mic92

@kalbasit
Copy link
Member Author

@GrahamcOfBorg build go-motion vimPlugins.vim-go

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: go-motion

The following builds were skipped because they don't evaluate on aarch64-linux: vimPlugins.vim-go

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/ry1pi9qjnxilfdnrlqag4prdyzh5q1q2-motion-unstable-2018-04-09-bin
shrinking /nix/store/ry1pi9qjnxilfdnrlqag4prdyzh5q1q2-motion-unstable-2018-04-09-bin/bin/motion
cannot find section .dynamic
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ry1pi9qjnxilfdnrlqag4prdyzh5q1q2-motion-unstable-2018-04-09-bin/bin
patching script interpreter paths in /nix/store/ry1pi9qjnxilfdnrlqag4prdyzh5q1q2-motion-unstable-2018-04-09-bin
checking for references to /build in /nix/store/ry1pi9qjnxilfdnrlqag4prdyzh5q1q2-motion-unstable-2018-04-09-bin...
cannot find section .dynamic
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
/nix/store/ry1pi9qjnxilfdnrlqag4prdyzh5q1q2-motion-unstable-2018-04-09-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: go-motion, vimPlugins.vim-go

Partial log (click to expand)

patching script interpreter paths in /nix/store/mnr063f2dgp3sm1n0bj86gr4210wi12q-vimplugin-vim-go-2018-10-23
/nix/store/mnr063f2dgp3sm1n0bj86gr4210wi12q-vimplugin-vim-go-2018-10-23/share/vim-plugins/vim-go/scripts/bench-syntax: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/mnr063f2dgp3sm1n0bj86gr4210wi12q-vimplugin-vim-go-2018-10-23/share/vim-plugins/vim-go/scripts/lint: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/mnr063f2dgp3sm1n0bj86gr4210wi12q-vimplugin-vim-go-2018-10-23/share/vim-plugins/vim-go/scripts/install-vim: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/mnr063f2dgp3sm1n0bj86gr4210wi12q-vimplugin-vim-go-2018-10-23/share/vim-plugins/vim-go/scripts/run-vim: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/mnr063f2dgp3sm1n0bj86gr4210wi12q-vimplugin-vim-go-2018-10-23/share/vim-plugins/vim-go/scripts/test: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/mnr063f2dgp3sm1n0bj86gr4210wi12q-vimplugin-vim-go-2018-10-23/share/vim-plugins/vim-go/scripts/docker-test: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/mnr063f2dgp3sm1n0bj86gr4210wi12q-vimplugin-vim-go-2018-10-23...
/nix/store/2f0jpcsdk5w53c0riipf2k63lbb542fg-motion-unstable-2018-04-09-bin
/nix/store/mnr063f2dgp3sm1n0bj86gr4210wi12q-vimplugin-vim-go-2018-10-23

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: go-motion

The following builds were skipped because they don't evaluate on aarch64-linux: vimPlugins.vim-go

Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


/nix/store/ry1pi9qjnxilfdnrlqag4prdyzh5q1q2-motion-unstable-2018-04-09-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: go-motion, vimPlugins.vim-go

Partial log (click to expand)

patching script interpreter paths in /nix/store/mnr063f2dgp3sm1n0bj86gr4210wi12q-vimplugin-vim-go-2018-10-23
/nix/store/mnr063f2dgp3sm1n0bj86gr4210wi12q-vimplugin-vim-go-2018-10-23/share/vim-plugins/vim-go/scripts/install-vim: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/mnr063f2dgp3sm1n0bj86gr4210wi12q-vimplugin-vim-go-2018-10-23/share/vim-plugins/vim-go/scripts/run-vim: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/mnr063f2dgp3sm1n0bj86gr4210wi12q-vimplugin-vim-go-2018-10-23/share/vim-plugins/vim-go/scripts/test: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/mnr063f2dgp3sm1n0bj86gr4210wi12q-vimplugin-vim-go-2018-10-23/share/vim-plugins/vim-go/scripts/bench-syntax: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/mnr063f2dgp3sm1n0bj86gr4210wi12q-vimplugin-vim-go-2018-10-23/share/vim-plugins/vim-go/scripts/lint: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/mnr063f2dgp3sm1n0bj86gr4210wi12q-vimplugin-vim-go-2018-10-23/share/vim-plugins/vim-go/scripts/docker-test: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/mnr063f2dgp3sm1n0bj86gr4210wi12q-vimplugin-vim-go-2018-10-23...
/nix/store/2f0jpcsdk5w53c0riipf2k63lbb542fg-motion-unstable-2018-04-09-bin
/nix/store/mnr063f2dgp3sm1n0bj86gr4210wi12q-vimplugin-vim-go-2018-10-23

@Mic92 Mic92 merged commit 9afa6f7 into NixOS:master Nov 15, 2018
@kalbasit kalbasit deleted the nixpkgs_vim-go-use-go-motion branch November 15, 2018 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants