Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write_stylus: fix loading libGL.so with libglvnd #50395

Merged
merged 2 commits into from Nov 15, 2018
Merged

write_stylus: fix loading libGL.so with libglvnd #50395

merged 2 commits into from Nov 15, 2018

Conversation

oyren
Copy link
Contributor

@oyren oyren commented Nov 15, 2018 •
edited

Motivation for this change

./Write: error while loading shared libraries: libGL.so.1: cannot open shared object file: No such file or directory

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@oyren
Merge pull request #1 from NixOS/master
0fa6fd2 
Merge Master
@oyren
added libglvnd to fix missing libGL.so.1
97abedb 
./Write: error while loading shared libraries: libGL.so.1: cannot open shared object file: No such file or directory
@Mic92 Mic92 merged commit 04b234e into NixOS:master Nov 15, 2018
@Mic92
Copy link
Member

Mic92 commented Nov 15, 2018

Is a backport required?

@oyren oyren deleted the fix_libGL_write_stylus branch November 15, 2018 15:09
@oyren
Copy link
Contributor Author

oyren commented Nov 15, 2018

Is a backport required?

Sry, what exactly do you mean by that?
Does it means that the package will be added to 18.09?

@Mic92
Copy link
Member

Mic92 commented Nov 15, 2018

The question was if we had the package in 18.09 and if the was affected by this bug.

@oyren
Copy link
Contributor Author

oyren commented Nov 15, 2018

Oh of course.
Yes the package was in 18.09, also was affect by the bug, so a backport would be nice.

Mic92 pushed a commit that referenced this pull request Nov 15, 2018
@oyren @Mic92
write_stylus: fix loading libGL.so with libglvnd (#50395)
533c5bc 
./Write: error while loading shared libraries: libGL.so.1: cannot open shared object file: No such file or directory

(cherry picked from commit 04b234e)
@Mic92
Copy link
Member

Mic92 commented Nov 15, 2018

backport: 533c5bc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oyren @Mic92 @GrahamcOfBorg