Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freesweep: use fetchFromGitHub instead of fetchurl as per #32997 #50388

Merged
merged 1 commit into from Nov 15, 2018

Conversation

kierdavis
Copy link
Contributor

@kierdavis kierdavis commented Nov 15, 2018

Motivation for this change

#32997

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • no change
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 15, 2018

@GrahamcOfBorg build freesweep

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: freesweep

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dd2albgk0glfj5cr9023x1zgmr29nk2d-freesweep-1.0.1
shrinking /nix/store/dd2albgk0glfj5cr9023x1zgmr29nk2d-freesweep-1.0.1/bin/freesweep
gzipping man pages under /nix/store/dd2albgk0glfj5cr9023x1zgmr29nk2d-freesweep-1.0.1/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dd2albgk0glfj5cr9023x1zgmr29nk2d-freesweep-1.0.1/bin
patching script interpreter paths in /nix/store/dd2albgk0glfj5cr9023x1zgmr29nk2d-freesweep-1.0.1
checking for references to /build in /nix/store/dd2albgk0glfj5cr9023x1zgmr29nk2d-freesweep-1.0.1...
/nix/store/dd2albgk0glfj5cr9023x1zgmr29nk2d-freesweep-1.0.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: freesweep

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7xn3416danyrhjckqxxqc7rknrgibhkg-freesweep-1.0.1
shrinking /nix/store/7xn3416danyrhjckqxxqc7rknrgibhkg-freesweep-1.0.1/bin/freesweep
gzipping man pages under /nix/store/7xn3416danyrhjckqxxqc7rknrgibhkg-freesweep-1.0.1/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7xn3416danyrhjckqxxqc7rknrgibhkg-freesweep-1.0.1/bin
patching script interpreter paths in /nix/store/7xn3416danyrhjckqxxqc7rknrgibhkg-freesweep-1.0.1
checking for references to /build in /nix/store/7xn3416danyrhjckqxxqc7rknrgibhkg-freesweep-1.0.1...
/nix/store/7xn3416danyrhjckqxxqc7rknrgibhkg-freesweep-1.0.1

@c0bw3b c0bw3b merged commit cd97805 into NixOS:master Nov 15, 2018
@kierdavis
Copy link
Contributor Author

Thanks 👍

@kierdavis kierdavis deleted the freesweep-src branch November 15, 2018 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants