Unbreak hg-git #50401
Merged
Unbreak hg-git #50401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Nov 15, 2018
| }; | ||
|
|
||
| propagatedBuildInputs = [ dulwich ]; | ||
| patches = [ | ||
| # Needs patch to work with Mercurial 4.8 | ||
| # https://bitbucket.org/durin42/hg-git/issues/264/unexpected-keyword-argument-createopts-hg |
There was a problem hiding this comment.
Can you use?
fetchpatch {
url = "https://bitbucket.org/rsalmaso/hg-git/commits/a778506fd4be0bf1afa75755f6ee9260fa234a0f/raw";
sha256 = "<insert-sha-sum>";
}
|
Sure, but could you briefly explain why? It seems it inserts a dependency on a bitbucket page making the build process more fragile. |
|
Then we don't need to carry the patch in our channel, it is clear where the patch comes from and our cache will also make sure that the patch is available when bitbucket is down. |
|
Thanks for the explanation! (And thanks for the quick review.) Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
hg-git did not work with the current Mercurial because of well-known issues,
one of which is fixed in the latest release, the second one of which has a simple
patch.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)