Skip to content

nixos/borgbackup: allow paths to be empty #51275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2018
Merged

nixos/borgbackup: allow paths to be empty #51275

merged 1 commit into from
Nov 30, 2018
+1 −1

Conversation

dotlambda
Copy link
Member

Motivation for this change

This is necessary in order to exclusively use --pattern or --patterns-from.
Fixes #51267.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @ToxicFrog

Sorry, something went wrong.

@dotlambda dotlambda requested a review from infinisil as a code owner November 30, 2018 11:03
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 30, 2018
nixos/borgbackup: allow paths to be empty or relative

Unverified

No user is associated with the committer email.
Learn about vigilant mode
193ae14 
This former necessary in order to exclusively use `--pattern` or `--patterns-from`.
Fixes NixOS#51267.
@dotlambda dotlambda force-pushed the borgbackup-empty-paths branch from 8708463 to 193ae14 Compare November 30, 2018 12:57
@dotlambda dotlambda merged commit 74e2834 into NixOS:master Nov 30, 2018
ToxicFrog added a commit to ToxicFrog/etc-nixos that referenced this pull request Mar 20, 2020
@ToxicFrog
Add placeholders for borgbackup

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
9c7efd8 
Can't actually use them until
NixOS/nixpkgs#51275 lands in the nixos-unstable
channel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dotlambda @GrahamcOfBorg