libgpiod: init at 2018-10-07 #51287
Closed
libgpiod: init at 2018-10-07 #51287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Nov 30, 2018
Mic92
reviewed
Nov 30, 2018
Co-Authored-By: expipiplus1 <github@sub.monoid.al>
worldofpeace
reviewed
Dec 3, 2018
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "libgpiod-${version}"; | ||
| version = "2018-10-07"; |
There was a problem hiding this comment.
Version should be:
Suggested change
| version = "2018-10-07"; | |
| version = "unstable-2018-10-07"; |
Per the package naming guidelines:
If a package is not a release but a commit from a repository, then the version part of the name must be the date of that (fetched) commit. The date must be in "YYYY-MM-DD" format. Also append "unstable" to the name - e.g., "pkgname-unstable-2014-09-23".
|
merged in 33e7330 |
|
Thanks!
…On Wed, 5 Dec 2018, 19:21 Jörg Thalheim, ***@***.***> wrote:
Closed #51287 <#51287>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#51287 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA0U3DWcT43g4hANZFgWD91VFRnC--bdks5u16whgaJpZM4Y7-55>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)