Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trezord: 2.0.24 -> 2.0.25 #51288

Merged
merged 1 commit into from Nov 30, 2018
Merged

trezord: 2.0.24 -> 2.0.25 #51288

merged 1 commit into from Nov 30, 2018

Conversation

1000101
Copy link
Member

@1000101 1000101 commented Nov 30, 2018

Motivation for this change

Upgrade of the package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 30, 2018

Changelog:
https://github.com/trezor/trezord-go/blob/master/CHANGELOG.md#2025---unreleased

@1000101
Copy link
Member Author

1000101 commented Nov 30, 2018

Changelog:
https://github.com/trezor/trezord-go/blob/master/CHANGELOG.md#2025---unreleased

Sorry, the repo maintainer made a mistake, you can check the 2.0.25 is the latest available version for download here: http://wallet.trezor.io/

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 30, 2018 •
edited

But is the changelog accurate, still?
It gives context as to what the update brings, if it contains some kind of security-related fix (not the case here) etc...
I was looking for it to get more context and justify the backport (your other PR)

@1000101
Copy link
Member Author

1000101 commented Nov 30, 2018

But is the changelog accurate, still?
It gives context as to what the update brings, if it contains some kind of security-related fix (not the case here) etc...
I was looking for it to get more context and justify the backport (your other PR)

Yes it is accurate. I am always trying to backport to stable release as well as it brings some significant changes (hidapi removal).

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 30, 2018

Ok, thanks for explaining.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build trezord

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: trezord

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6irk0jircbczkasmscnpmdsqchmjax5f-trezord-go-2.0.25-bin
shrinking /nix/store/6irk0jircbczkasmscnpmdsqchmjax5f-trezord-go-2.0.25-bin/bin/trezord-go
strip is /nix/store/bbla06nbjnpi55x9b3zm945vq1mf5fbh-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6irk0jircbczkasmscnpmdsqchmjax5f-trezord-go-2.0.25-bin/bin
patching script interpreter paths in /nix/store/6irk0jircbczkasmscnpmdsqchmjax5f-trezord-go-2.0.25-bin
checking for references to /build/ in /nix/store/6irk0jircbczkasmscnpmdsqchmjax5f-trezord-go-2.0.25-bin...
strip is /nix/store/bbla06nbjnpi55x9b3zm945vq1mf5fbh-binutils-2.30/bin/strip
/nix/store/6irk0jircbczkasmscnpmdsqchmjax5f-trezord-go-2.0.25-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: trezord

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/i5lhhws6q698hlsrq1pvipwflmhz5xm9-trezord-go-2.0.25-bin
shrinking /nix/store/i5lhhws6q698hlsrq1pvipwflmhz5xm9-trezord-go-2.0.25-bin/bin/trezord-go
strip is /nix/store/6s8dkfj3irwv52cap2hd9k7gaddklfs1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/i5lhhws6q698hlsrq1pvipwflmhz5xm9-trezord-go-2.0.25-bin/bin
patching script interpreter paths in /nix/store/i5lhhws6q698hlsrq1pvipwflmhz5xm9-trezord-go-2.0.25-bin
checking for references to /build/ in /nix/store/i5lhhws6q698hlsrq1pvipwflmhz5xm9-trezord-go-2.0.25-bin...
strip is /nix/store/6s8dkfj3irwv52cap2hd9k7gaddklfs1-binutils-2.30/bin/strip
/nix/store/i5lhhws6q698hlsrq1pvipwflmhz5xm9-trezord-go-2.0.25-bin

@worldofpeace worldofpeace merged commit 0f4bb32 into NixOS:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@1000101 @c0bw3b @worldofpeace @GrahamcOfBorg