Fix 4 broken builds in python-unstable #51279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
force-pushed
the
python-unstable
branch
from
93e6f5a
to
d4f9f5c
Compare
Downgrade package. 2018.XX.XX are not official releases? Fixes dask-image build as well.
costrouc
force-pushed
the
fix-dask-image
branch
from
466b528
to
c42f15d
Compare
FRidh
reviewed
Nov 30, 2018
| @@ -16,6 +16,7 @@ | |||
| buildPythonPackage rec { | |||
| pname = "gidgethub"; | |||
| version = "3.0.0"; | |||
| format = "flit"; | |||
There was a problem hiding this comment.
the tarball comes with a setup.py, so that should work?
There was a problem hiding this comment.
I thought so too but it does not build without format = "flit";. Here is the error message.
these derivations will be built:
/nix/store/qw39libx4yhj00c7wxz9wjnjvkykq343-python3.7-gidgethub-3.0.0.drv
building '/nix/store/qw39libx4yhj00c7wxz9wjnjvkykq343-python3.7-gidgethub-3.0.0.drv'...
unpacking sources
unpacking source archive /nix/store/zpnz9frn34alsi4a5nkd0f95vl17k6zb-gidgethub-3.0.0.tar.gz
source root is gidgethub-3.0.0
setting SOURCE_DATE_EPOCH to timestamp 1536623112 of file gidgethub-3.0.0/README.rst
patching sources
configuring
building
error in gidgethub setup command: 'extras_require' must be a dictionary whose values are strings or lists of strings containing valid project/version requirement specifiers.
builder for '/nix/store/qw39libx4yhj00c7wxz9wjnjvkykq343-python3.7-gidgethub-3.0.0.drv' failed with exit code 1There was a problem hiding this comment.
Should be ready to merge if this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixing several broken builds. Thanks to https://discourse.nixos.org/t/where-to-find-current-failed-hydra-builds-in-master/1545 for showing me how to easily find broken builds.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)