Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] all-packages.nix: Rename self (wrong) to super #51278

Closed
wants to merge 1 commit into from
Closed

[WIP] all-packages.nix: Rename self (wrong) to super #51278

wants to merge 1 commit into from

Conversation

roberth
Copy link
Member

@roberth roberth commented Nov 30, 2018 •
edited

Motivation for this change

self in all-packages.nix has the wrong meaning. This deprecates it. It is an internal name, so only people who patch all-packages.nix are affected by this change.

This is a light-weight solution similar to what I proposed in #34881

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@roberth roberth mentioned this pull request Nov 30, 2018
Open
@roberth roberth changed the title all-packages.nix: Rename self (wrong) to super [WIP] all-packages.nix: Rename self (wrong) to super Nov 30, 2018
@roberth
Copy link
Member Author

roberth commented Nov 30, 2018

ofborg shows that the rename was correct, but super is not the right name. See issue #34881. Closing.

@roberth roberth closed this Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roberth @GrahamcOfBorg