Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gandi-cli: 0.19 -> 1.3 #51284

Merged
merged 1 commit into from Nov 30, 2018
Merged

gandi-cli: 0.19 -> 1.3 #51284

merged 1 commit into from Nov 30, 2018

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Nov 30, 2018 •
edited

Motivation for this change

gandi-cli 0.19 is hopelessly out of date.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes Nov 30, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be using buildPythonApplication instead of buildPythonPackage.

See the python section of the nixpkgs for details on how to use it.

@kampka
Copy link
Contributor Author

kampka commented Nov 30, 2018

@worldofpeace all suggestions applied, thanks for reviewing 👍

worldofpeace
worldofpeace suggested changes Nov 30, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably look over https://github.com/Gandi/gandi.cli/blob/master/setup.py and also see if the tests are appropriate now.

At a glance, I can see that they have python3 support.
So I think we should default to that with python3Packages.

@kampka
Copy link
Contributor Author

kampka commented Nov 30, 2018

You should probably look over https://github.com/Gandi/gandi.cli/blob/master/setup.py and also see if the tests are appropriate now.

They are not, tests still call the API and fail because of it.

At a glance, I can see that they have python3 support.
So I think we should default to that with python3Packages.

Done.

@worldofpeace
Copy link
Contributor

You should probably look over https://github.com/Gandi/gandi.cli/blob/master/setup.py and also see if the tests are appropriate now.

They are not, tests still call the API and fail because of it.

At a glance, I can see that they have python3 support.
So I think we should default to that with python3Packages.

Done.

Sounds good.

Testing the build here.

@GrahamcOfBorg build gandi-cli

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gandi-cli

Partial log (click to expand)

Successfully installed gandi.cli-1.3
/build/source
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/q2kckq5n3rzm1i2d2m3i0jb19ypj2y4q-gandi-cli-1.3
strip is /nix/store/bbla06nbjnpi55x9b3zm945vq1mf5fbh-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/q2kckq5n3rzm1i2d2m3i0jb19ypj2y4q-gandi-cli-1.3/lib  /nix/store/q2kckq5n3rzm1i2d2m3i0jb19ypj2y4q-gandi-cli-1.3/bin
patching script interpreter paths in /nix/store/q2kckq5n3rzm1i2d2m3i0jb19ypj2y4q-gandi-cli-1.3
checking for references to /build/ in /nix/store/q2kckq5n3rzm1i2d2m3i0jb19ypj2y4q-gandi-cli-1.3...
wrapping `/nix/store/q2kckq5n3rzm1i2d2m3i0jb19ypj2y4q-gandi-cli-1.3/bin/gandi'...
/nix/store/q2kckq5n3rzm1i2d2m3i0jb19ypj2y4q-gandi-cli-1.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gandi-cli

Partial log (click to expand)

Successfully installed gandi.cli-1.3
/build/source
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ssaf20232if6lym2qp2zr52qzv0ka2pk-gandi-cli-1.3
strip is /nix/store/6s8dkfj3irwv52cap2hd9k7gaddklfs1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ssaf20232if6lym2qp2zr52qzv0ka2pk-gandi-cli-1.3/lib  /nix/store/ssaf20232if6lym2qp2zr52qzv0ka2pk-gandi-cli-1.3/bin
patching script interpreter paths in /nix/store/ssaf20232if6lym2qp2zr52qzv0ka2pk-gandi-cli-1.3
checking for references to /build/ in /nix/store/ssaf20232if6lym2qp2zr52qzv0ka2pk-gandi-cli-1.3...
wrapping `/nix/store/ssaf20232if6lym2qp2zr52qzv0ka2pk-gandi-cli-1.3/bin/gandi'...
/nix/store/ssaf20232if6lym2qp2zr52qzv0ka2pk-gandi-cli-1.3

worldofpeace
worldofpeace approved these changes Nov 30, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executes fine locally.

Only concern left is that this is without a maintainer.
I don't think we have a rule for this, but would you mind volunteering @kampka?

@kampka
Copy link
Contributor Author

kampka commented Nov 30, 2018

Sure, why not.
Added myself as maintainer.

@worldofpeace worldofpeace merged commit 22926c8 into NixOS:master Nov 30, 2018
@worldofpeace
Copy link
Contributor

@kampka Thanks for your contribution ❇️

@kampka kampka deleted the upgrade-gandi-cli branch December 1, 2018 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kampka @worldofpeace @GrahamcOfBorg