Skip to content

fped: init at unstable-2017-05-11 #51285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2019
Merged

fped: init at unstable-2017-05-11 #51285

merged 1 commit into from
Apr 23, 2019
+46 −0

Conversation

expipiplus1
Copy link
Contributor

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build fped

@worldofpeace worldofpeace changed the title fped: init at 2017-05-11 fped: init at unstable-2017-05-11 Dec 3, 2018
worldofpeace
worldofpeace reviewed Dec 3, 2018
View reviewed changes
pkgs/applications/science/electronics/fped/default.nix Outdated
};

LEX="flex";
RGBDEF="${netpbm}/share/netpbm/misc/rgb.txt";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a comment declaring its necessity?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember why it was necessary, so I've removed it and things still build...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@expipiplus1 This is needed #51285 (comment).
Things still built because it was on a different linux distro and without sandboxing.

Corrected in d571ec0

@expipiplus1
Copy link
Contributor Author

@worldofpeace I've made your corrections.

@expipiplus1
Copy link
Contributor Author

@GrahamcOfBorg build fped

@GrahamcOfBorg GrahamcOfBorg added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Apr 11, 2019
@expipiplus1
Copy link
Contributor Author

@worldofpeace Thanks for the suggestions, done.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1-10 labels Apr 12, 2019
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build fped

@worldofpeace
Copy link
Contributor

Build failed with

ppmcolormask: can't open color names dictionary file from the path '/usr/local/netpbm/rgb.txt:/usr/share/netpbm/rgb.txt:/etc/X11/rgb.txt:/usr/lib/X11/rgb.txt:/usr/share/X11/rgb.txt:/usr/X11R6/lib/X11/rgb.txt' and Environment variable RGBDEF not set.  Set RGBDEF to the pathname of your rgb.txt file or don't use color names.
make: *** [Makefile:116: icons/point.xpm] Error 1

So I guess another environment variable to set?

@jtojnar
Copy link
Member

jtojnar commented Apr 12, 2019 via email

@worldofpeace
Copy link
Contributor

Yay, that's what we just removed.
…
On Fri, 12 Apr 2019, 20:48 worldofpeace, @.***> wrote: Build failed with ppmcolormask: can't open color names dictionary file from the path '/usr/local/netpbm/rgb.txt:/usr/share/netpbm/rgb.txt:/etc/X11/rgb.txt:/usr/lib/X11/rgb.txt:/usr/share/X11/rgb.txt:/usr/X11R6/lib/X11/rgb.txt' and Environment variable RGBDEF not set. Set RGBDEF to the pathname of your rgb.txt file or don't use color names. make: *** [Makefile:116: icons/point.xpm] Error 1 So I guess another environment variable to set? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#51285 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AArCY9pme2k4erB7nnE4S-kry_x6W5cgks5vgNTmgaJpZM4Y746g .

Yep it was #51285 (comment)

Yay?

@expipiplus1
Copy link
Contributor Author

expipiplus1 commented Apr 13, 2019 via email

@worldofpeace
Copy link
Contributor

@expipiplus1 Can you squash the commits?

@expipiplus1
Copy link
Contributor Author

@worldofpeace done, thanks!

@worldofpeace worldofpeace merged commit c8c0bd1 into NixOS:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@expipiplus1 @worldofpeace @jtojnar @GrahamcOfBorg