Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anki: 2.1.6-beta1 -> 2.1.6-beta2, fix python 3.7 #51272

Merged
merged 2 commits into from Dec 4, 2018
Merged

anki: 2.1.6-beta1 -> 2.1.6-beta2, fix python 3.7 #51272

merged 2 commits into from Dec 4, 2018

Conversation

binarin
Copy link
Contributor

@binarin binarin commented Nov 30, 2018

Motivation for this change

anki was upgraded by #50379 and then a switch to python 3.7 was done. So currently anki is broken.

Upstream PR with the same patch: ankitects/anki#266

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@binarin
anki: 2.1.6-beta1 -> 2.1.6-beta2, fix python 3.7
8d61b9d 
With recent switch to python 3.7 this was no longer building.

Upstream PR with the same patch: ankitects/anki#266
@jtojnar
Copy link
Contributor

jtojnar commented Nov 30, 2018

Can you obtain the patch from https://github.com/dae/anki/commit/3d69aa9ce454a151ba75deafd7de117af2c7307d.patch using fetchpatch. Also please add an comment with a short description of the patch and a link to the upstream PR above the fetchpatch call.

@binarin
Copy link
Contributor Author

binarin commented Dec 1, 2018

@jtojnar done

@rasendubi
Copy link
Member

@GrahamcOfBorg build anki

rasendubi
rasendubi approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@rasendubi rasendubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also fixes #51503

@rasendubi rasendubi merged commit 33b9aa4 into NixOS:master Dec 4, 2018
@rasendubi rasendubi mentioned this pull request Dec 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasendubi rasendubi rasendubi approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@binarin @jtojnar @rasendubi @GrahamcOfBorg