Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][backport-18.09]: kernel: enable MLX5_CORE_EN when possible #51292

Merged
merged 1 commit into from Nov 30, 2018
Merged

[WIP][backport-18.09]: kernel: enable MLX5_CORE_EN when possible #51292

merged 1 commit into from Nov 30, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 30, 2018 •
edited

DO NOT MERGE YET. I want to test the build

backport of #49470

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@grahamc @Mic92
kernel: enable MLX5_CORE_EN when possible
4934f82 
Hydra's builders from Packet.net use this option a lot, causing
lots of slow deploys.

(cherry picked from commit d65b39a)
@Mic92 Mic92 changed the base branch from master to release-18.09 November 30, 2018 18:11
@grahamc grahamc removed 2.status: merge conflict 6.topic: emacs 6.topic: erlang 6.topic: GNOME GNOME desktop environment and its underlying platform labels Nov 30, 2018
@Mic92
Copy link
Member Author

Mic92 commented Nov 30, 2018

@GrahamcOfBorg eval

@Mic92 Mic92 changed the title [backport-18.09]: kernel: enable MLX5_CORE_EN when possible [WIP][backport-18.09]: kernel: enable MLX5_CORE_EN when possible Nov 30, 2018
@Mic92 Mic92 merged commit 9b71a92 into NixOS:release-18.09 Nov 30, 2018
@Mic92 Mic92 deleted the mlx5-core-en branch November 30, 2018 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @grahamc @GrahamcOfBorg