Skip to content

nvidia: expose nvidia_x11_legacy390 #51294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2018
Merged

nvidia: expose nvidia_x11_legacy390 #51294

merged 1 commit into from
Dec 27, 2018
+14 −11

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Nov 30, 2018 •
edited by veprbl
Loading

Motivation for this change

Closes #49679

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@eadwu eadwu requested a review from infinisil as a code owner November 30, 2018 18:54
@eadwu eadwu mentioned this pull request Nov 30, 2018
Closed
@eadwu
nvidia: expose nvidia_x11_legacy390

Unverified

No user is associated with the committer email.
Learn about vigilant mode
ea1be31
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 30, 2018
@eadwu eadwu force-pushed the nvidia_x11/legacy_390 branch from 33339d2 to ea1be31 Compare November 30, 2018 18:58
@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Nov 30, 2018
@jokogr jokogr mentioned this pull request Dec 9, 2018
Merged
11 tasks
@nek0
Copy link
Contributor

nek0 commented Dec 15, 2018

can somebody please speed up the process here? I would like to use this driver.

@eadwu
Copy link
Member Author

eadwu commented Dec 16, 2018

See #51768 (comment) if you don't use a local nixpkgs.

@nek0
Copy link
Contributor

nek0 commented Dec 16, 2018

thanks a lot. this worked.

@billksun
Copy link
Contributor

billksun commented Dec 21, 2018 •
edited
Loading

@nek0 , what did you do to make it work?

I put this in my configuration.nix and it didn't do anything:

  nixpkgs.config = {
    allowUnfree = true;
    
    packageOverrides = super: let self = super.pkgs; in
    {
        linuxPackages = super.linuxPackages_latest.extend (self: super: {
          nvidiaPackages = super.nvidiaPackages // {
            stable = self.nvidiaPackages.stable_390;
          };
        });
    };
  };

@nek0
Copy link
Contributor

nek0 commented Dec 22, 2018

@sib-null You also need the following line in your configuration.

services.xserver.videoDrivers = [ "nvidia" ];

veprbl
veprbl approved these changes Dec 22, 2018
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@veprbl
Copy link
Member

veprbl commented Dec 27, 2018

@GrahamcOfBorg eval

@veprbl veprbl merged commit 3edd5cb into NixOS:master Dec 27, 2018
@billksun billksun mentioned this pull request Jan 3, 2019
Closed
@eadwu eadwu deleted the nvidia_x11/legacy_390 branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eadwu @nek0 @billksun @veprbl @GrahamcOfBorg