Add bisect_ppx and bisect_ppx-ocamlbuild #51276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is my first PR against nixpkgs, so any comment or advice is appreciated. |
nomeata
force-pushed
the
ocaml-bisect
branch
from
8d5d0c5
to
7621523
Compare
|
Thanks for your contribution. These two files seem to have a lot in common. Can you try to factorize a bit the common parts? For instance, the |
Mic92
reviewed
Dec 1, 2018
pkgs/development/ocaml-modules/bisect_ppx-ocamlbuild/default.nix
Outdated
Show resolved
Hide resolved
Mic92
reviewed
Dec 1, 2018
pkgs/development/ocaml-modules/bisect_ppx-ocamlbuild/default.nix
Outdated
Show resolved
Hide resolved
|
Thanks for your suggestions. Better? |
vbgl
requested changes
Dec 1, 2018
pkgs/development/ocaml-modules/bisect_ppx-ocamlbuild/default.nix
Outdated
Show resolved
Hide resolved
Only if I have to :-) |
vbgl
approved these changes
Dec 2, 2018
|
@GrahamcOfBorg build ocamlPackages.bisect_ppx ocamlPackages.bisect_ppx-ocamlbuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.