adding check to the key-pair #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| kp = self._conn.get_key_pair(self.keypair_name) | ||
| except IndexError as e: | ||
| kp = None |
There was a problem hiding this comment.
You could set the state to missing directly right ?
Suggested change
| kp = None | |
| self.state = self.MISSING |
There was a problem hiding this comment.
In fact, we need to check if the kp = None even when the IndexError exception wasn't caught. We can take as an example the use case where the get_key_pair returns None without an exception occurring, then we need to set the state to MISSING.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.