-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rambox: 0.6.1 -> 0.6.2 #50262
rambox: 0.6.1 -> 0.6.2 #50262
Conversation
@GrahamcOfBorg build rambox |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: rambox Partial log (click to expand)
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: rambox Partial log (click to expand)
|
Oh, oops, unfree. Checking locally. |
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: rambox Partial log (click to expand)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.6.1 builds for me locally just fine. This, however, does not:
❯ nix-build . -A rambox
these derivations will be built:
/nix/store/74agph7jnqd9851dmm3kwmpajm0bj3ng-source.drv
/nix/store/1qzcxmw2dsf8vxlnkiv8w02gs6q793km-node_modules.drv
/nix/store/7z6halz8c6rz2f2al1cfnggzfd6wxnky-rambox-bare-0.6.2.drv
/nix/store/l4hnwv9vlxvh81hjkyig2jq4pcnh53q3-Rambox.desktop.drv
/nix/store/h3wmn6giang6c9ba0n1yc1svlm3jx1bx-rambox-0.6.2.drv
building '/nix/store/74agph7jnqd9851dmm3kwmpajm0bj3ng-source.drv'...
trying https://github.com/saenzramiro/rambox/archive/0.6.2.tar.gz
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 133 0 133 0 0 517 0 --:--:-- --:--:-- --:--:-- 517
100 134 0 134 0 0 287 0 --:--:-- --:--:-- --:--:-- 130k
100 22.7M 0 22.7M 0 0 4527k 0 --:--:-- 0:00:05 --:--:-- 6378k
unpacking source archive /build/0.6.2.tar.gz
building '/nix/store/1qzcxmw2dsf8vxlnkiv8w02gs6q793km-node_modules.drv'...
npm WARN using --force I sure hope you know what you are doing.
added 158 packages from 137 contributors and audited 2671 packages in 3.327s
found 4 vulnerabilities (2 low, 2 high)
run `npm audit fix` to fix them, or `npm audit` for details
fixed-output derivation produced path '/nix/store/l2j3ig4xrs0na6wc4f0ns8rx428zy7gv-node_modules' with sha256 hash '0hbw47653wh159c34f0rlj3p7xy0lvsyp0wh2hl35kv3fnsfbbm0' instead of the expected hash '0mg1ilz65qyxgh5zg1f8fhx7ygz10w8ifamflpwbk8mrvqpkjlvr'
cannot build derivation '/nix/store/7z6halz8c6rz2f2al1cfnggzfd6wxnky-rambox-bare-0.6.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/h3wmn6giang6c9ba0n1yc1svlm3jx1bx-rambox-0.6.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/h3wmn6giang6c9ba0n1yc1svlm3jx1bx-rambox-0.6.2.drv' failed
@@ -18,7 +18,7 @@ stdenv.mkDerivation rec { | |||
inherit src; | |||
|
|||
nodejs = nodejs-8_x; | |||
sha256 = "0hbw47653wh159c34f0rlj3p7xy0lvsyp0wh2hl35kv3fnsfbbm0"; | |||
sha256 = "0mg1ilz65qyxgh5zg1f8fhx7ygz10w8ifamflpwbk8mrvqpkjlvr"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got: 0hbw47653wh159c34f0rlj3p7xy0lvsyp0wh2hl35kv3fnsfbbm0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I set nodejs to 8.12.0, that change the hash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no, not good if those things happen: @yegortimoshenko
It should really not depend on the node version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the long run we should switch to a model like in: #44076
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I also have 8.12.0 in my branch but still get 0hbw47653wh159c34f0rlj3p7xy0lvsyp0wh2hl35kv3fnsfbbm0
I got this error with rambox-0.6.1
Sorry if I do it wrong |
Mhm it might the case that building node-modules fixed output get messed up if the sandbox is not enabled leading to a different checksum. |
@jeci-sarl this can be closed now. |
Motivation for this change
can't install rambox-0.6.1 anymore
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)