Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rambox: 0.6.1 -> 0.6.2 #50262

Closed
wants to merge 3 commits into from
Closed

Conversation

jeremie-lesage
Copy link

Motivation for this change

can't install rambox-0.6.1 anymore

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Nov 12, 2018

@GrahamcOfBorg build rambox

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: rambox

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: rambox

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@srhb
Copy link
Contributor

srhb commented Nov 12, 2018

Oh, oops, unfree. Checking locally.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: rambox

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


Copy link
Contributor

@srhb srhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.6.1 builds for me locally just fine. This, however, does not:

❯ nix-build . -A rambox
these derivations will be built:
  /nix/store/74agph7jnqd9851dmm3kwmpajm0bj3ng-source.drv
  /nix/store/1qzcxmw2dsf8vxlnkiv8w02gs6q793km-node_modules.drv
  /nix/store/7z6halz8c6rz2f2al1cfnggzfd6wxnky-rambox-bare-0.6.2.drv
  /nix/store/l4hnwv9vlxvh81hjkyig2jq4pcnh53q3-Rambox.desktop.drv
  /nix/store/h3wmn6giang6c9ba0n1yc1svlm3jx1bx-rambox-0.6.2.drv
building '/nix/store/74agph7jnqd9851dmm3kwmpajm0bj3ng-source.drv'...

trying https://github.com/saenzramiro/rambox/archive/0.6.2.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   133    0   133    0     0    517      0 --:--:-- --:--:-- --:--:--   517
100   134    0   134    0     0    287      0 --:--:-- --:--:-- --:--:--  130k
100 22.7M    0 22.7M    0     0  4527k      0 --:--:--  0:00:05 --:--:-- 6378k
unpacking source archive /build/0.6.2.tar.gz
building '/nix/store/1qzcxmw2dsf8vxlnkiv8w02gs6q793km-node_modules.drv'...
npm WARN using --force I sure hope you know what you are doing.
added 158 packages from 137 contributors and audited 2671 packages in 3.327s
found 4 vulnerabilities (2 low, 2 high)
  run `npm audit fix` to fix them, or `npm audit` for details
fixed-output derivation produced path '/nix/store/l2j3ig4xrs0na6wc4f0ns8rx428zy7gv-node_modules' with sha256 hash '0hbw47653wh159c34f0rlj3p7xy0lvsyp0wh2hl35kv3fnsfbbm0' instead of the expected hash '0mg1ilz65qyxgh5zg1f8fhx7ygz10w8ifamflpwbk8mrvqpkjlvr'
cannot build derivation '/nix/store/7z6halz8c6rz2f2al1cfnggzfd6wxnky-rambox-bare-0.6.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/h3wmn6giang6c9ba0n1yc1svlm3jx1bx-rambox-0.6.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/h3wmn6giang6c9ba0n1yc1svlm3jx1bx-rambox-0.6.2.drv' failed

@@ -18,7 +18,7 @@ stdenv.mkDerivation rec {
inherit src;

nodejs = nodejs-8_x;
sha256 = "0hbw47653wh159c34f0rlj3p7xy0lvsyp0wh2hl35kv3fnsfbbm0";
sha256 = "0mg1ilz65qyxgh5zg1f8fhx7ygz10w8ifamflpwbk8mrvqpkjlvr";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got: 0hbw47653wh159c34f0rlj3p7xy0lvsyp0wh2hl35kv3fnsfbbm0

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set nodejs to 8.12.0, that change the hash

Copy link
Member

@Mic92 Mic92 Nov 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no, not good if those things happen: @yegortimoshenko
It should really not depend on the node version.

Copy link
Member

@Mic92 Mic92 Nov 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the long run we should switch to a model like in: #44076

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I also have 8.12.0 in my branch but still get 0hbw47653wh159c34f0rlj3p7xy0lvsyp0wh2hl35kv3fnsfbbm0

@jeremie-lesage
Copy link
Author

I got this error with rambox-0.6.1

building '/nix/store/m14qmj6wk26cfk4i59x63wfg33c9l1ja-SenchaCmd-6.6.0.13-linux-amd64.sh.zip.drv'...

trying https://cdn.sencha.com/cmd/6.6.0.13/no-jre/SenchaCmd-6.6.0.13-linux-amd64.sh.zip
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 85.5M  100 85.5M    0     0  5480k      0  0:00:15  0:00:15 --:--:-- 5183k
building '/nix/store/2g11q8p52csggdrp29p9rjl21c13wpsk-source.drv'...

trying https://github.com/saenzramiro/rambox/archive/0.6.1.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   133    0   133    0     0    420      0 --:--:-- --:--:-- --:--:--   419
100   134    0   134    0     0    191      0 --:--:-- --:--:-- --:--:--   191
100 22.7M    0 22.7M    0     0  2585k      0 --:--:--  0:00:09 --:--:-- 3433k
unpacking source archive /tmp/nix-build-source.drv-0/0.6.1.tar.gz
building '/nix/store/x1980470v4nvak33nbqlm9kkqsq5p3qm-sencha-bare-6.6.0.13.drv'...
unpacking sources
unpacking source archive /nix/store/3jq720ymwfnjspc28a43p9mr2q1294ks-SenchaCmd-6.6.0.13-linux-amd64.sh.zip
source root is .
setting SOURCE_DATE_EPOCH to timestamp 1528368918 of file ./SenchaCmd-6.6.0.13-linux-amd64.sh
patching sources
configuring
building
no Makefile, doing nothing
installing
Starting Installer ...
Fontconfig warning: "/etc/fonts/fonts.conf", line 5: unknown element "its:rules"
Fontconfig warning: "/etc/fonts/fonts.conf", line 6: unknown element "its:translateRule"
Fontconfig error: "/etc/fonts/fonts.conf", line 6: invalid attribute 'translate'
Fontconfig error: "/etc/fonts/fonts.conf", line 6: invalid attribute 'selector'
Fontconfig error: "/etc/fonts/fonts.conf", line 7: invalid attribute 'xmlns:its'
Fontconfig error: "/etc/fonts/fonts.conf", line 7: invalid attribute 'version'
Fontconfig warning: "/etc/fonts/fonts.conf", line 9: unknown element "description"
Fontconfig error: Cannot load config file from /etc/fonts/fonts.conf
The installation directory has been set to /nix/store/4648mv8if12ad8h68ighl1k0ph97hlfr-sencha-bare-6.6.0.13.
Extracting files ...
Finishing installation ...
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4648mv8if12ad8h68ighl1k0ph97hlfr-sencha-bare-6.6.0.13
shrinking /nix/store/4648mv8if12ad8h68ighl1k0ph97hlfr-sencha-bare-6.6.0.13/bin/linux-x64/phantomjs/phantomjs
shrinking /nix/store/4648mv8if12ad8h68ighl1k0ph97hlfr-sencha-bare-6.6.0.13/bin/linux-x64/vcdiff/vcdiff
shrinking /nix/store/4648mv8if12ad8h68ighl1k0ph97hlfr-sencha-bare-6.6.0.13/bin/linux-x64/node/node
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4648mv8if12ad8h68ighl1k0ph97hlfr-sencha-bare-6.6.0.13/lib  /nix/store/4648mv8if12ad8h68ighl1k0ph97hlfr-sencha-bare-6.6.0.13/bin 
patching script interpreter paths in /nix/store/4648mv8if12ad8h68ighl1k0ph97hlfr-sencha-bare-6.6.0.13
/nix/store/4648mv8if12ad8h68ighl1k0ph97hlfr-sencha-bare-6.6.0.13/sencha: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /tmp/nix-build-sencha-bare-6.6.0.13.drv-1 in /nix/store/4648mv8if12ad8h68ighl1k0ph97hlfr-sencha-bare-6.6.0.13...
building '/nix/store/gvmqm4ln0asdypdqwhkywwi5ihsfzkx4-node_modules.drv'...
npm WARN using --force I sure hope you know what you are doing.
added 158 packages from 137 contributors and audited 2671 packages in 3.783s
found 4 vulnerabilities (2 low, 2 high)
  run `npm audit fix` to fix them, or `npm audit` for details
fixed-output derivation produced path '/nix/store/a2k3r60q5q5qqdffwvzpv5aiqhd23qad-node_modules' with sha256 hash '0mg1ilz65qyxgh5zg1f8fhx7ygz10w8ifamflpwbk8mrvqpkjlvr' instead of the expected hash '0hbw47653wh159c34f0rlj3p7xy0lvsyp0wh2hl35kv3fnsfbbm0'
cannot build derivation '/nix/store/554gh4926hm52s7kmimb751f7z7b345d-rambox-bare-0.6.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/nsg74qbzn9lyw79g30iminxsmwhixx3k-rambox-0.6.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/nsg74qbzn9lyw79g30iminxsmwhixx3k-rambox-0.6.1.drv' failed

Sorry if I do it wrong

@Mic92
Copy link
Member

Mic92 commented Nov 12, 2018

Mhm it might the case that building node-modules fixed output get messed up if the sandbox is not enabled leading to a different checksum.

@aanderse
Copy link
Member

@jeci-sarl this can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants