Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxPackages_custom should accept a list of kernel patches #50241

Closed
wants to merge 1 commit into from

Conversation

tathougies
Copy link
Contributor

Motivation for this change

When building a custom kernel, it is often nice to be able to supply custom patches. This simply allows linuxPackages_custom to be called with a kernelPatches list, which is passed on to the manual configurator.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@symphorien
Copy link
Member

Somewhat unrelated: do you know about boot.kernelPatches (https://nixos.org/nixos/options.html#kernelpatches ) ?

@tathougies
Copy link
Contributor Author

@symphorien Yes, but that only helps if you're using NixOS, rather than nixpkgs directly (I think).

@teto
Copy link
Member

teto commented Nov 12, 2018

I feel like for this kind of more advanced stuff you should directly use linuxPackagesFor (pkgs.linuxManualConfig { or instead forward all arguments { ... } @ args: ... pkgs.linuxManualConfig { inherit args; }, the function being small, it should be easy for its users to look for what parameters are available.

@tathougies
Copy link
Contributor Author

@teto What scared me from doing that is the recurseIntoAttrs. What does that function do?

@joachifm
Copy link
Contributor

@tathougies it's a hint to the evaluator for what to do about attributes that evaluate to sets (to recurse or not), see e.g., https://github.com/NixOS/nix/blob/master/src/libexpr/get-drvs.cc#L350

@mmahut
Copy link
Member

mmahut commented Aug 10, 2019

Are there any updates on this pull request, please?

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 18, 2021
@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@AndersonTorres
Copy link
Member

Closing as dead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants