Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable more X libraries for no-x-libs options #50240

Closed
wants to merge 1 commit into from

Conversation

tathougies
Copy link
Contributor

Motivation for this change

The environment.noXlibs option is supposed to modify nixpkgs such that no unnecessary X libraries are pulled in. However, there are some packages that are perfectly usable without X libraries which are not changed. This is by no means complete of course, but these packages are pulled in by the base system.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@@ -27,6 +27,11 @@ with lib;
fonts.fontconfig.enable = false;

nixpkgs.overlays = singleton (const (super: {
cairo = super.cairo.override { glSupport = false; };
libdevil = super.libdevil.override { libGL = null; libX11 = null; };
gnupg22 = super.gnupg22.override { guiSupport = false; };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #49270

@qolii
Copy link
Contributor

qolii commented Mar 21, 2019

How is this looking? And are changes in this direction welcome in general?

@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@infinisil
Copy link
Member

Doesn't seem to be much interest in this, closing for now.

@infinisil infinisil closed this Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants