Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PICARD-1410: load vorbis file with invalid rating #1031

Merged
merged 2 commits into from Nov 12, 2018
Merged

PICARD-1410: load vorbis file with invalid rating #1031

merged 2 commits into from Nov 12, 2018

Conversation

phw
Copy link
Member

@phw phw commented Nov 12, 2018

Summary

Having a Vorbis file with an invalid value (i.e. non-numeric string) for the rating tag makes Picard fail to load that file.

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

Solution

Implement error handling and added tests

Action

@phw phw merged commit 64b36fe into metabrainz:master Nov 12, 2018
@phw phw deleted the PICARD-1410-load-vorbis-file-with-invalid-rating branch November 12, 2018 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zas zas zas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@phw @zas