Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libjpeg-turbo: 1.5.3 -> 2.0.1 #50249

Merged
merged 2 commits into from Nov 28, 2018
Merged

libjpeg-turbo: 1.5.3 -> 2.0.1 #50249

merged 2 commits into from Nov 28, 2018

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Nov 11, 2018 •
edited

Motivation for this change

Update to version 2.0.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Nov 15, 2018 •
edited

fixes CVE-2018-11813 cc @ckauhaus

@orivej
Copy link
Contributor

orivej commented Nov 15, 2018

Please update to 2.0.1.

@romildo romildo changed the title libjpeg-turbo: 1.5.3 -> 2.0.0 libjpeg-turbo: 1.5.3 -> 2.0.1 Nov 16, 2018
@romildo
Copy link
Contributor Author

romildo commented Nov 16, 2018

Please update to 2.0.1

Done.

@vcunat vcunat self-assigned this Nov 23, 2018
vcunat
vcunat reviewed Nov 23, 2018
View reviewed changes
pkgs/development/libraries/libjpeg-turbo/default.nix Outdated
cmakeFlagsArray+=(
"-DCMAKE_INSTALL_BINDIR=$bin/bin"
"-DWITH_JPEG8=1"
"-DWITH_JPEG9=1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We weren't been using --with-jpegN up to now. This changes soname from libjpeg.so.62 to libjpeg.so.8. I expect it will be safer for us to drop these two lines.

...backward-incompatible with libjpeg v6b

@vcunat
libjpeg-turbo: don't change ABI, don't add *.a
dd69374 
(refers to the parent commit)
@vcunat vcunat changed the base branch from master to staging November 23, 2018 14:49
@vcunat
Copy link
Member

vcunat commented Nov 23, 2018 •
edited

The rebuild amount is very large, and the CVE seems of relatively low severity, so I'd go through staging. Any more comments before merging?

@ckauhaus
Copy link
Contributor

CVE-2018-11813

@Mic92 Whitelisted. Thanks for the heads-up.

@vcunat vcunat merged commit dd69374 into NixOS:staging Nov 28, 2018
vcunat added a commit that referenced this pull request Nov 28, 2018
@vcunat
Merge #50249: libjpeg-turbo: 1.5.3 -> 2.0.1
834e7c4 
(into staging)
@romildo romildo deleted the upd.libjpeg-turbo branch November 28, 2018 09:27
vcunat added a commit that referenced this pull request Dec 21, 2018
@vcunat
Merge #50249: libjpeg-turbo: 1.5.3 -> 2.0.1
bdf88aa 
(cherry picked from commit 834e7c4)
Fixes CVE-2018-11813.
I see no issues with this reported for staging/master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat left review comments

Assignees

@vcunat vcunat

Labels
1.severity: security 8.has: package (update) 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@romildo @Mic92 @orivej @vcunat @ckauhaus @roberth @GrahamcOfBorg