Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "androidsdk: 25.2.5 -> 26.1.1, license agreement" #50263

Closed
wants to merge 1 commit into from
Closed

Revert "androidsdk: 25.2.5 -> 26.1.1, license agreement" #50263

wants to merge 1 commit into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 12, 2018 •
edited

This reverts commit 950608b.

This broke the emulator: #49515 (comment)

cc @clefru @nicknovitski

matthewbauer
matthewbauer approved these changes Nov 12, 2018
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. You might be able to keep the licenseAccepted stuff because we definitely should have that here (androidsdk has a license you need to agree to).

@corngood corngood mentioned this pull request Nov 12, 2018
Merged
9 tasks
@corngood
Copy link
Contributor

@Mic92 #50276 has the changes from #49515 with my fixup applied.

I've been using the emulator quite a bit without any serious problems, so it may be a good alternative to reverting.

@Mic92 Mic92 closed this Nov 12, 2018
@Mic92 Mic92 deleted the androidsdk branch November 12, 2018 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @corngood @matthewbauer @GrahamcOfBorg