Skip to content

sphinx_1_2: use uppercase for override #50269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 489 commits into from
Closed

sphinx_1_2: use uppercase for override #50269

wants to merge 489 commits into from
+994 −976

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented Nov 12, 2018 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

FRidh added 30 commits November 11, 2018 14:45
@FRidh
python: py3dns: 3.1.1a -> 3.2.0
f645e36
@FRidh
python: pyacoustid: 1.1.0 -> 1.1.5
00384a2
@FRidh
python: pyalgotrade: 0.16 -> 0.20
a0a5992
@FRidh
python: PyChromecast: 2.2.0 -> 2.3.0
f49bcd1
@FRidh
python: pycparser: 2.18 -> 2.19
14a94a2
@FRidh
python: pycryptodome: 3.6.6 -> 3.7.0
a06ca0a
@FRidh
python: pycryptodomex: 3.6.6 -> 3.7.0
1d5f620
@FRidh
python: pycryptopp: 0.6.0.1206569328141510525648634803928199668821045…
389d863 
…408958 -> 0.7.1.869544967005693312591928092448767568728501330214
@FRidh
python: pydenticon: 0.2 -> 0.3.1
a961952
@FRidh
python: pydot_ng: 1.0.0 -> 2.0.0
ebaaccb
@FRidh
python: pyelftools: 0.24 -> 0.25
93c186b
@FRidh
python: pyenchant: 1.6.6 -> 2.0.0
23041f5
@FRidh
python: pygal: 2.3.1 -> 2.4.0
67394b2
@FRidh
python: pygit2: 0.26.4 -> 0.27.2
ec6efe7
@FRidh
python: pyhepmc: 0.5.0 -> 1.0.1
34e2fcf
@FRidh
python: pyhomematic: 0.1.50 -> 0.1.51
5a2e58f
@FRidh
python: pyinsane2: 2.0.10 -> 2.0.13
f972741
@FRidh
python: pylama: 7.6.5 -> 7.6.6
c3c0e4c
@FRidh
python: pymatgen: 2018.9.30 -> 2018.10.18
b764704
@FRidh
python: pymongo: 3.7.1 -> 3.7.2
b3fa416
@FRidh
python: pync: 1.4 -> 2.0.3
cad8742
@FRidh
python: pynisher: 0.4.2 -> 0.5.0
791cf8d
@FRidh
python: pyobjc: 4.2.2 -> 5.1.1
6c7202d
@FRidh
python: pyopencl: 2018.1.1 -> 2018.2.1
4d674f8
@FRidh
python: pyparsing: 2.2.2 -> 2.3.0
e67394a
@FRidh
python: pyperclip: 1.6.5 -> 1.7.0
adc706c
@FRidh
python: pyqtgraph: 0.9.10 -> 0.10.0
2c19756
@FRidh
python: pyramid: 1.9.1 -> 1.10
be43cee
@FRidh
python: pyramid_exclog: 0.7 -> 1.0
7a85606
@FRidh
python: pyramid_jinja2: 2.5 -> 2.7
3275c1d
FRidh and others added 21 commits November 11, 2018 14:47
@FRidh
python: pylint: 1.9.2 -> 1.9.3
0958c18
@FRidh
python: pymongo: 2.9.1 -> 2.9.5
2fe1a79
@FRidh
python: pyramid: 1.10 -> 1.10.1
5c7b462
@FRidh
python: pysrim: 0.5.9 -> 0.5.10
8e4dc50
@FRidh
python: pytest-sugar: 0.9.1 -> 0.9.2
a6004d5
@FRidh
python: pytest-xdist: 1.24.0 -> 1.24.1
ce93b98
@FRidh
python: python-hosts: 0.4.1 -> 0.4.5
4ff9009
@FRidh
python: python-json-logger: 0.1.9 -> 0.1.10
afa86cd
@FRidh
python: qtconsole: 4.4.2 -> 4.4.3
a073ae3
@FRidh
python: regex: 2018.11.03 -> 2018.11.07
b95c6d7
@FRidh
python: requests: 2.20.0 -> 2.20.1
50cc0dd
@FRidh
python: responses: 0.10.2 -> 0.10.3
1bb5c05
@FRidh
python: ruamel.yaml: 0.15.76 -> 0.15.77
a548b6f
@FRidh
python: SQLAlchemy: 1.2.13 -> 1.2.14
4ace578
@FRidh
python: stripe: 2.11.0 -> 2.11.1
087fd06
@FRidh
python: uproot-methods: 0.2.6 -> 0.2.7
cad04c4
@FRidh
python: uproot: 3.2.9 -> 3.2.10
c36f751
@FRidh
python: virtualenv-clone: 0.2.5 -> 0.2.6
c5e58fe
python.pkgs.pyjwt: disable tests
38ffecf 
They are broken due to a pytest upgrade.
Revert "sphinx: don't use capital for pname"
bd47106 
This reverts commit d2e6608.
@Synthetica9
sphinx_1_2: use uppercase for override
ee4f058
@Synthetica9 Synthetica9 requested a review from FRidh as a code owner November 12, 2018 13:19
@Synthetica9 Synthetica9 mentioned this pull request Nov 12, 2018
Merged
9 tasks
dotlambda
dotlambda requested changes Nov 12, 2018
View reviewed changes
pkgs/top-level/python-packages.nix
@@ -3744,10 +3744,10 @@ in {
sphinx = callPackage ../development/python-modules/sphinx { };

sphinx_1_2 = self.sphinx.overridePythonAttrs rec {
name = "sphinx-1.2.3";
name = "Sphinx-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pname

pkgs/top-level/python-packages.nix
@@ -3744,10 +3744,10 @@ in {
sphinx = callPackage ../development/python-modules/sphinx { };

sphinx_1_2 = self.sphinx.overridePythonAttrs rec {
name = "sphinx-1.2.3";
name = "Sphinx-${version}";
version = "1.2.3";
src = pkgs.fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oldAttrs.src.override

@dotlambda
Copy link
Member

Are you sure this version of sphinx is still needed? Maybe we can get rid of it by updating Arelle?

@Synthetica9
Copy link
Member Author

Are you sure this version of sphinx is still needed? Maybe we can get rid of it by updating Arelle?

I'm honestly not sure. Removing it would be fine to me as well.

@Synthetica9 Synthetica9 mentioned this pull request Nov 13, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Synthetica9 @dotlambda @GrahamcOfBorg @FRidh