Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coqPackages.bignums: enable for Coq version 8.9 #50264

Merged
merged 1 commit into from Nov 19, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Nov 12, 2018

Motivation for this change

bignums is compatible with Coq 8.9

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

vbgl commented Nov 12, 2018

@GrahamcOfBorg build coqPackages_8_9.bignums

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: coqPackages_8_9.bignums

Partial log (click to expand)

make[2]: Leaving directory '/build/source'
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/736pphas0l59fasj21wxlirkd0ak7s2y-coq8.9-bignums
shrinking /nix/store/736pphas0l59fasj21wxlirkd0ak7s2y-coq8.9-bignums/lib/coq/8.9/user-contrib/Bignums/bignums_syntax_plugin.cmxs
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/736pphas0l59fasj21wxlirkd0ak7s2y-coq8.9-bignums/lib
patching script interpreter paths in /nix/store/736pphas0l59fasj21wxlirkd0ak7s2y-coq8.9-bignums
checking for references to /build in /nix/store/736pphas0l59fasj21wxlirkd0ak7s2y-coq8.9-bignums...
/nix/store/736pphas0l59fasj21wxlirkd0ak7s2y-coq8.9-bignums

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: coqPackages_8_9.bignums

Partial log (click to expand)

INSTALL bignums_syntax_plugin.cmxa /nix/store/96ri7fnhg8c863liy53iyfyv7vz2096f-coq8.9-bignums/lib/coq/8.9/user-contrib/Bignums/
INSTALL bignums_syntax_plugin.cmx /nix/store/96ri7fnhg8c863liy53iyfyv7vz2096f-coq8.9-bignums/lib/coq/8.9/user-contrib/Bignums/
make[2]: Entering directory '/private/tmp/nix-build-coq8.9-bignums.drv-0/source'
make[2]: Leaving directory '/private/tmp/nix-build-coq8.9-bignums.drv-0/source'
make[1]: Leaving directory '/private/tmp/nix-build-coq8.9-bignums.drv-0/source'
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/96ri7fnhg8c863liy53iyfyv7vz2096f-coq8.9-bignums/lib
patching script interpreter paths in /nix/store/96ri7fnhg8c863liy53iyfyv7vz2096f-coq8.9-bignums
/nix/store/96ri7fnhg8c863liy53iyfyv7vz2096f-coq8.9-bignums

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: coqPackages_8_9.bignums

Partial log (click to expand)

make[2]: Leaving directory '/build/source'
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/svkgkxf8y1m25z1lyw669r31w095yvdj-coq8.9-bignums
shrinking /nix/store/svkgkxf8y1m25z1lyw669r31w095yvdj-coq8.9-bignums/lib/coq/8.9/user-contrib/Bignums/bignums_syntax_plugin.cmxs
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/svkgkxf8y1m25z1lyw669r31w095yvdj-coq8.9-bignums/lib
patching script interpreter paths in /nix/store/svkgkxf8y1m25z1lyw669r31w095yvdj-coq8.9-bignums
checking for references to /build in /nix/store/svkgkxf8y1m25z1lyw669r31w095yvdj-coq8.9-bignums...
/nix/store/svkgkxf8y1m25z1lyw669r31w095yvdj-coq8.9-bignums

@vbgl vbgl merged commit c4cad8c into NixOS:master Nov 19, 2018
@vbgl vbgl deleted the coq-bignums-8.9 branch November 19, 2018 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants