Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diskus: init at 0.4.0 #50252

Merged
merged 1 commit into from Nov 12, 2018
Merged

diskus: init at 0.4.0 #50252

merged 1 commit into from Nov 12, 2018

Conversation

fuerbringer
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@samueldr
Copy link
Member

👋 Hi! Thanks for your first contribution!

Looking, I can't see anything wrong in the code, let's see what the CI says about this.

@GrahamcOfBorg build diskus

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: diskus

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: diskus

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/di26jbynpwcxxi6bww5hrimqw4zkd2xg-diskus-0.4.0
shrinking /nix/store/di26jbynpwcxxi6bww5hrimqw4zkd2xg-diskus-0.4.0/bin/diskus
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/di26jbynpwcxxi6bww5hrimqw4zkd2xg-diskus-0.4.0/bin
patching script interpreter paths in /nix/store/di26jbynpwcxxi6bww5hrimqw4zkd2xg-diskus-0.4.0
checking for references to /build in /nix/store/di26jbynpwcxxi6bww5hrimqw4zkd2xg-diskus-0.4.0...
/nix/store/di26jbynpwcxxi6bww5hrimqw4zkd2xg-diskus-0.4.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: diskus

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7bzfgshgi1q81x3ii97p0xl0iv29va8n-diskus-0.4.0
shrinking /nix/store/7bzfgshgi1q81x3ii97p0xl0iv29va8n-diskus-0.4.0/bin/diskus
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7bzfgshgi1q81x3ii97p0xl0iv29va8n-diskus-0.4.0/bin
patching script interpreter paths in /nix/store/7bzfgshgi1q81x3ii97p0xl0iv29va8n-diskus-0.4.0
checking for references to /build in /nix/store/7bzfgshgi1q81x3ii97p0xl0iv29va8n-diskus-0.4.0...
/nix/store/7bzfgshgi1q81x3ii97p0xl0iv29va8n-diskus-0.4.0

@samueldr samueldr merged commit 63399ae into NixOS:master Nov 12, 2018
@fuerbringer fuerbringer deleted the diskus branch November 12, 2018 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fuerbringer @samueldr @GrahamcOfBorg @Janik-Haag